Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix two issues related to hb_uuid and hb_cache_id targeting keys #3568

Merged
merged 4 commits into from
Feb 27, 2019

Conversation

jsnellbaker
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

This PR incorporates some fixes related to the hb_uuid and hb_cache_id targeting keys.

Some issues that were fixed:

  • due to the order in which the code was executed, the bid.adserverTargeting.hb_uuid and bid.adserverTargeting.hb_cache_id fields weren't properly populated with the bid's videoCacheKey after it came back from Prebid Cache. This caused other functions that pulled the targeting keys (like pbjs.getAdserverTargetingForAdUnitCode()) to be missing this information when it was otherwise expected to be there.

  • a consequence to the above issue, when the publisher tried to overwrite the values for these keys in the pbjs.bidderSettings feature - the overwrites wouldn't work because the bid.videoCacheKey wasn't populated at the time these bidderSettings values were used.

The changes in this PR addresses the above issues through mainly moving the code around to populate the bid.adserverTargeting object once we know the bid is complete (ie back from prebid cache for that use-case).

Note - removed the dfpAdServerVideo code since it's now redundant.

Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkendall07 mkendall07 requested a review from bretg February 22, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants