-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanmedianet: Add cleanmedianet bidder adapter #3582
Cleanmedianet: Add cleanmedianet bidder adapter #3582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to use the passed in url & utils url parsing function
modules/cleanmedianetBidAdapter.js
Outdated
import { BANNER, VIDEO } from '../src/mediaTypes'; | ||
|
||
export const helper = { | ||
getTopFrame: function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use bidderRequest.refererInfo for getting the url
http://prebid.org/dev-docs/bidder-adaptor.html#bidrequest-parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
modules/cleanmedianetBidAdapter.js
Outdated
startsWith: function(str, search) { | ||
return str.substr(0, search.length) === search; | ||
}, | ||
getTopWindowDomain: function(url) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use utils.parse for extracting the hostname from the url
Line 27 in 68dfb64
export function parse(url, options) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Hi @mike-chowla, |
docs PR prebid/prebid.github.io#1134 |
Type of change
[X] New bidder adapter
Description of change
Added
cleanmedianet
as a new bidder adapter