Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buyer data to Index Exchange bid responses #3585

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

kelvin-chappell
Copy link
Contributor

Type of change

  • Feature

Description of change

Adds buyer data to Index Exchange responses, following the format specified in #3115.
We have already made this change to our fork, here.

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

/cc @ix-prebid-support

@kelvin-chappell
Copy link
Contributor Author

The circleci test failure doesn't appear to be caused by this PR, as far as I can tell.

@mkendall07 mkendall07 self-assigned this Feb 28, 2019
@mkendall07 mkendall07 self-requested a review February 28, 2019 14:56
@mkendall07
Copy link
Member

you might need to rebase on master to fix the circle CI error.

@mkendall07
Copy link
Member

@ix-prebid-support @indexexchange ping

@ix-prebid-support
Copy link
Contributor

@mkendall07 This looks good to merge into the next release. One observation is that it doesn't appear that these ext params make the Prebid Server response. This would prevent the data from reaching the analytics module for Ozone. Has this been tested and are there any concerns here?

cc @kelvin-chappell

@kelvin-chappell
Copy link
Contributor Author

@ix-prebid-support This PR is purely to make buyer data available to the client-side adapter. It's only been tested in that context. I haven't considered what changes would be required to support analytics in Ozone as that isn't in the scope of the PR.

@ix-prebid-support
Copy link
Contributor

@kelvin-chappell Understood, and appreciate the quick clarification.

Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks everyone for their input.

@mkendall07 mkendall07 merged commit e74bf6c into prebid:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants