Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YIELDONE adapter - add buildRequests payload params #3611

Merged
merged 26 commits into from
Mar 11, 2019
Merged

YIELDONE adapter - add buildRequests payload params #3611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
3df0b3f
added UserSync
kusapan Sep 4, 2018
4c040be
added UserSync Unit Test
kusapan Sep 6, 2018
beb5947
Merge remote-tracking branch 'fork-origin/master'
kusapan Sep 12, 2018
9542cf9
Merge remote-tracking branch 'fork-origin/master'
kusapan Oct 3, 2018
35d0efd
Merge remote-tracking branch 'fork-origin/master'
kusapan Oct 10, 2018
d542506
support for multi sizes
kusapan Oct 10, 2018
c279995
register the adapter as supporting video
kusapan Oct 10, 2018
89be5a9
Merge remote-tracking branch 'fork-origin/master'
kusapan Oct 15, 2018
cb3746a
supporting video
kusapan Oct 18, 2018
1e38585
Merge remote-tracking branch 'fork-origin/master'
kusapan Oct 18, 2018
738e490
change requestId acquisition method
kusapan Oct 18, 2018
81c753e
fix the parameter name of dealID
kusapan Oct 18, 2018
c7e7177
update test parameters
kusapan Oct 18, 2018
979173e
Merge remote-tracking branch 'fork-origin/master'
kusapan Oct 23, 2018
8d63502
Merge remote-tracking branch 'fork-origin/master'
kusapan Oct 25, 2018
88ccca7
support instream video
kusapan Oct 25, 2018
404fafa
add test for bidRequest
kusapan Oct 25, 2018
fad6c20
add test for interpretResponse
kusapan Oct 25, 2018
eb6918b
add test params
kusapan Oct 25, 2018
029fad3
add note to documentaion
kusapan Oct 26, 2018
08fccbc
Merge remote-tracking branch 'fork-origin/master'
kusapan Oct 26, 2018
f3bf739
conflict resolution
kusapan Dec 19, 2018
4aabe19
Merge remote-tracking branch 'fork-origin/master'
kusapan Feb 28, 2019
827de26
add payload params
kusapan Feb 28, 2019
ac774c0
add test
kusapan Feb 28, 2019
6f698e6
delete tmax param
kusapan Mar 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/yieldoneBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,14 @@ export const spec = {
const cb = Math.floor(Math.random() * 99999999999);
const referrer = encodeURIComponent(utils.getTopWindowUrl());
const bidId = bidRequest.bidId;
const unitCode = bidRequest.adUnitCode;
const payload = {
v: 'hb1',
p: placementId,
cb: cb,
r: referrer,
uid: bidId,
uc: unitCode,
t: 'i'
};

Expand Down
5 changes: 5 additions & 0 deletions test/spec/modules/yieldoneBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ describe('yieldoneBidAdapter', function() {
expect(request[0].data.w).to.equal('300');
expect(request[0].data.h).to.equal('250');
});

it('adUnitCode should be sent as uc parameters on any requests', function () {
expect(request[0].data.uc).to.equal('adunit-code1');
expect(request[1].data.uc).to.equal('adunit-code2');
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a unit test!

});

describe('interpretResponse', function () {
Expand Down