PubCommonId - Add support for localStorage #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging d764eefd8f637f28eb0821d99eb46087012109ab into 6cd91f9 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
pycnvr
force-pushed
the
pubcid_local_storage
branch
from
d764eef to
5ce7a59
Compare
|
I am going to rework this a bit to avoid copying id from local storage to cookie all the time. |
idettman
approved these changes
Mar 29, 2019
|
@idettman Thanks. |
|
@pycnvr let me know when you're ready for review, thanks! |
|
@idettman Sorry about the delay. It should be ready soon. Thanks. |
pycnvr
force-pushed
the
pubcid_local_storage
branch
from
2d5d243 to
95fb0de
Compare
|
@idettman Ready for review once again. Thanks. |
idettman
added
needs 2nd review
|
@bretg Would it be possible to include this in the next release? |
idettman
removed
the
needs 2nd review
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* Add support for localStorage * Pubcid uses local storage first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Enable PubCommonId module to store id in localStorage. This is for publishers that have not yet switch to the new user id module. As a transition aid, the pubcid is written both as a cookie and also to the localStorage. Cookie values, if present, will be copied into localStorage. Otherwise a new id will be generated and written to both locations.
The default expiration time has also been reduced to 1 year.
Be sure to test the integration with your adserver using the Hello World sample page.
contact email of the adapter’s maintainer
pyang@conversantmedia.com
official adapter submission
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
PubCommonId - Add support for local storage prebid.github.io#1217
Other information