issues in utilities/refactor of type-checking usage, "bidder" conflict with documentation #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for better perf., add 'bidder' to bid response to match documentation on custom key-values
| try { | ||
| keyValues[key] = value(custBidObj); | ||
| } catch (e) { | ||
| utils.logError("invalid function during k/v targeting", "BIDMANAGER"); |
There was a problem hiding this comment.
I like sending the "class" with the error message. Maybe we should add a 3rd param in utils.logError() for Exception so we don't lose that info?
There was a problem hiding this comment.
yeah good idea I'll add that
mkendall07
added a commit
that referenced
this pull request
Sep 1, 2015
issues in utilities/refactor of type-checking usage, "bidder" conflict with documentation
marian-r
added a commit
to aol/Prebid.js
that referenced
this pull request
Nov 2, 2016
…3.1 to master * commit '512c5786d825013efde7bbbaaa1106ed080bb859': Refactoring, code cleanup Fixed reporting of timed out bids in AOL analytics
patmmccann
pushed a commit
that referenced
this pull request
Jul 12, 2024
DecayConstant
pushed a commit
to mediavine/Prebid.js
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isAand helper functionshasOwnPropertynot being defined in utilitiesbidderon bidResponse frombidderCodeto match docs here -- http://prebid.org/publisher-api.html#configure-ad-server-targeting