Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShowHeroes Adapter #3733

Merged
merged 1 commit into from
Apr 19, 2019
Merged

ShowHeroes Adapter #3733

merged 1 commit into from
Apr 19, 2019

Conversation

vadim-mazzherin
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: "showheroes-bs",
  params: {
     playerId: '0151f985-fb1a-4f37-bb26-cfc62e43ec05',
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vadim-mazzherin Code is LGTM. Just one question, i tried the banner bidder params shared by you on our hello_world page and in bid response your endpoint sent vastTag for banner. Is it correct ?

@vadim-mazzherin
Copy link
Contributor Author

@jaiminpanchal27 Yes, it is correct

@jaiminpanchal27 jaiminpanchal27 merged commit 12eceea into prebid:master Apr 19, 2019
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants