Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VI Bid Adapter Changes #3748

Merged
merged 29 commits into from
May 3, 2019
Merged

VI Bid Adapter Changes #3748

merged 29 commits into from
May 3, 2019

Conversation

alpadotsh
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Sends more parameters to VI adserver.

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@jsnellbaker jsnellbaker self-requested a review April 22, 2019 16:12
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlexPashkov

I reviewed these changes and had a question that I wanted to clarify.
I noticed in the buildRequests function, there was a reference to a bid param named useSizes. Is this something that should be documented in your .md file?

Additionally, I noticed that you tagged this PR that it would have corresponding changes on the prebid.org site. Did you submit the docs PR? I checked the repo, but I didn't see one at this time. If you haven't, can you please put that together?

Copy link
Contributor Author

@alpadotsh alpadotsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added new params prop to the bidder's .md file

Copy link
Contributor Author

@alpadotsh alpadotsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, no other changes in the docs are needed.

@bretg
Copy link
Collaborator

bretg commented May 1, 2019

@AlexPashkov - jsnellbaker is referring to this page -- https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/vi.md

@jsnellbaker - anything else here besides the docs update?

@jsnellbaker
Copy link
Collaborator

Everything else looks okay. Once the docs PR is submitted, we can merge this PR.

Copy link
Contributor Author

@alpadotsh alpadotsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsnellbaker jsnellbaker merged commit 38e50d2 into prebid:master May 3, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* Add new viBidAdapter

* Change request schema

* Min area is 1

* Send bidId

* Refactor getDocumentHeight

* Add getDocumentHeight test

* Remove getWindowHeight

* Add getOffset tests

* Add getWindowParents tests

* Add getTopmostReachableWindow test

* Add curWindow

* Add more tests

* Add getIframeType tests

* Rename hostile->nonfriendly

* Add more params to bid request

* Add getFrameElements tests

* Add area tests

* Add more tests

* Add more tests

* Add getViUserId

* Add fallback to localStorage

* Change bid URL

* Add media-types

* Remove user id

* withCredentials: true

* Add https

* Remove getViUserId from spec

* Add mergeSizes

* Add useSizes param
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants