-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VI Bid Adapter Changes #3748
VI Bid Adapter Changes #3748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AlexPashkov
I reviewed these changes and had a question that I wanted to clarify.
I noticed in the buildRequests
function, there was a reference to a bid param named useSizes
. Is this something that should be documented in your .md file?
Additionally, I noticed that you tagged this PR that it would have corresponding changes on the prebid.org site. Did you submit the docs PR? I checked the repo, but I didn't see one at this time. If you haven't, can you please put that together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added new params prop to the bidder's .md file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess, no other changes in the docs are needed.
@AlexPashkov - jsnellbaker is referring to this page -- https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/vi.md @jsnellbaker - anything else here besides the docs update? |
Everything else looks okay. Once the docs PR is submitted, we can merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the PR prebid/prebid.github.io#1300
* Add new viBidAdapter * Change request schema * Min area is 1 * Send bidId * Refactor getDocumentHeight * Add getDocumentHeight test * Remove getWindowHeight * Add getOffset tests * Add getWindowParents tests * Add getTopmostReachableWindow test * Add curWindow * Add more tests * Add getIframeType tests * Rename hostile->nonfriendly * Add more params to bid request * Add getFrameElements tests * Add area tests * Add more tests * Add more tests * Add getViUserId * Add fallback to localStorage * Change bid URL * Add media-types * Remove user id * withCredentials: true * Add https * Remove getViUserId from spec * Add mergeSizes * Add useSizes param
Type of change
Description of change
Sends more parameters to VI adserver.
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information