Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect ad blocker recovered requests + send dynamic parameters to adapter + minor fixes #3749

Merged
merged 18 commits into from
Apr 30, 2019
Merged

Detect ad blocker recovered requests + send dynamic parameters to adapter + minor fixes #3749

merged 18 commits into from
Apr 30, 2019

Conversation

bjorn-lw
Copy link
Contributor

@bjorn-lw bjorn-lw commented Apr 15, 2019

Type of change

  • Feature
  • [x ] Other

Description of change

Added support for detecting if request was originally ad blocked, but recovered.
Added support for sending in dynamic parameters to adapter.
Some fixes for how ttr is calculated in analytics adapter.

@bjorn-lw
Copy link
Contributor Author

@idettman the failed CircleCI tests, are they caused by this PR or was there a problem with the build process?

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman merged commit 40a4ac6 into prebid:master Apr 30, 2019
@idettman idettman added the LGTM label Apr 30, 2019
jacekburys-quantcast pushed a commit to jacekburys-quantcast/Prebid.js that referenced this pull request May 15, 2019
…pter + minor fixes (prebid#3749)

* Livewrapped bid and analytics adapter

* Fixed some tests for browser compatibility

* Fixed some tests for browser compatibility

* Changed analytics adapter code name

* Fix double quote in debug message

* modified how gdpr is being passed

* Added support for Publisher Common ID Module

* Corrections for ttr in analytics

* ANalytics updates

* Auction start time stamp changed

* Detect recovered ad blocked requests
Make it possible to pass dynamic parameters to adapter
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
…pter + minor fixes (prebid#3749)

* Livewrapped bid and analytics adapter

* Fixed some tests for browser compatibility

* Fixed some tests for browser compatibility

* Changed analytics adapter code name

* Fix double quote in debug message

* modified how gdpr is being passed

* Added support for Publisher Common ID Module

* Corrections for ttr in analytics

* ANalytics updates

* Auction start time stamp changed

* Detect recovered ad blocked requests
Make it possible to pass dynamic parameters to adapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants