Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReklamStore Adapter Update #3784

Merged
merged 5 commits into from
Apr 29, 2019
Merged

ReklamStore Adapter Update #3784

merged 5 commits into from
Apr 29, 2019

Conversation

ReklamStoreIT
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Deleted Request param "dbg" and change netRevenue value.

ReklamStoreIT and others added 5 commits March 14, 2019 00:44
ReklamStore Bid Adapter
Added unit test for user sync
Update bid adapter
Reklamstore Adapter Update
@ReklamStoreIT
Copy link
Contributor Author

`Edge 17.17134.0 (Windows 10.0.0): Executed 3639 of 3640 (skipped 1) SUCCESS (12.985 secs / 6.024 secs)
Safari 11.1.2 (Mac OS X 10.13.6): Executed 3639 of 3640 (skipped 1) SUCCESS (8.883 secs / 4.788 secs)
Firefox 65.0.0 (Windows 10.0.0): Executed 3642 of 3643 (skipped 1) SUCCESS (12.426 secs / 4.208 secs)
Chrome 72.0.3626 (Windows 10.0.0): Executed 3642 of 3643 (skipped 1) SUCCESS (8.745 secs / 3.322 secs)
Chrome 71.0.3578 (Windows 10.0.0): Executed 3642 of 3643 (1 FAILED) (skipped 1) (9.924 secs / 3.436 secs)
IE 11.0.0 (Windows 10.0.0): Executed 3639 of 3640 (skipped 1) SUCCESS (9.462 secs / 4.725 secs)
Safari 12.0.0 (Mac OS X 10.14.0): Executed 3639 of 3640 (skipped 1) SUCCESS (5.298 secs / 3.076 secs)
Edge 16.16299.0 (Windows 10.0.0): Executed 3639 of 3640 (skipped 1) SUCCESS (13.845 secs / 7.283 secs)
Firefox 64.0.0 (Windows 10.0.0): Executed 3642 of 3643 (skipped 1) SUCCESS (12.433 secs / 4.954 secs)
TOTAL: 1 FAILED, 32762 SUCCESS

  1. "after each" hook for "should return false if cookie value source is a boolean"
    Yieldbot Adapter Unit Tests sessionBlocked
    AssertionError: expected '' to equal null
    at Context. (webpack:///test/spec/modules/yieldbotBidAdapter_spec.js:524:55 <- test/test_index.js:195530:170)

[12:19:24] 'test' errored after 2.57 min
[12:19:24] Error: Karma tests failed with exit code 1
at /home/circleci/Prebid.js/gulpfile.js:215:12
at removeAllListeners (/home/circleci/Prebid.js/node_modules/karma/lib/server.js:354:9)
at webServer.close (/home/circleci/Prebid.js/node_modules/karma/lib/server.js:365:13)
at Server.close (net.js:1527:9)
at Object.onceWrapper (events.js:293:19)
at emitNone (events.js:91:20)
at Server.emit (events.js:188:7)
at emitCloseNT (net.js:1577:8)
at _combinedTickCallback (internal/process/next_tick.js:77:11)
at process._tickDomainCallback (internal/process/next_tick.js:128:9)

[12:19:24] 'test' errored after 3.12 min
Exited with code 1`
Fails while testing but no problem with my local tests.

@bretg
Copy link
Collaborator

bretg commented Apr 29, 2019

re-ran tests, succeeded

@bretg bretg merged commit c6069f1 into prebid:master Apr 29, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* ReklamStore Bid Adapter

ReklamStore Bid Adapter

* Added unit test for user sync

Added unit test for user sync

* Update bid adapter

Update bid adapter

* Reklamstore Adapter Update

Reklamstore Adapter Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants