feat(krux): add Krux Link adapter #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -39,7 +38,7 @@ | |||
| var d = document; | |||
| var pbs = d.createElement("script"); | |||
| pbs.type = "text/javascript"; | |||
| pbs.src = '/build/dist/prebid.js'; | |||
| pbs.src = '/build/dev/prebid.js'; | |||
There was a problem hiding this comment.
Should integration examples include the dev build, or is it better to keep the dist reference if people are likely to copy-paste this code?
There was a problem hiding this comment.
If they copied this verbatim, then it probably wouldn't work unless they host the script on their site at /build/dist/prebid.js. So it should be pretty obvious they would need to set the path correctly. I'd suggest a comment rather than make the integrating testing more difficult.
|
Looks good, confirmed bids back and ad rendered, tests are green. Reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new adapter for the Krux Link Header Bidder.