-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgid adapter: add support of currency.adServerCurrency #3850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-chowla
changed the title
add support of currency.adServerCurrency
mgid adapter: add support of currency.adServerCurrency
May 27, 2019
robertrmartinez
approved these changes
May 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Maybe add a unit test in a future PR to mock config.getConfig('adServerCurrency'); and make sure the request is built exactly how you expect!
Thank you!
kd-appier
added a commit
to appier/Prebid.js
that referenced
this pull request
May 30, 2019
* 'master' of https://github.com/appier/Prebid.js: (160 commits) Increment pre version Prebid 2.17.0 Release mgid adapter: add support of currency.adServerCurrency (prebid#3850) We want to remove bidfloor if not set by pb (prebid#3866) aardvark tdid support (prebid#3860) auction key limiter feature (prebid#3825) minor updates to consentManagement tests (prebid#3849) Rhythmone Adapter - Multiple ad size support, rewrite tests, update docs. (prebid#3854) Adding bidfloor to video imp req (prebid#3863) adding Outstream mediaType to EMX Digital (prebid#3840) Added optional dealId parameter to bid response. (prebid#3858) Update rtbhouseBidAdapter.md (prebid#3857) Updated the bidder code in the test ad unit. (prebid#3844) change in Aardvark adapter to handle additional data (prebid#3821) Refactor bid response - remove unnecessary properties (prebid#3807) Increment pre version Prebid 2.16.0 release fix how native sizes are passed in AppNexus adapter (prebid#3832) updated ozone adapter from v1.4.4 -> v2.0.0 (prebid#3828) Adding advertiserId to appnexus adapter (prebid#3833) ...
kd-appier
added a commit
to appier/Prebid.js
that referenced
this pull request
May 30, 2019
* master: (160 commits) Increment pre version Prebid 2.17.0 Release mgid adapter: add support of currency.adServerCurrency (prebid#3850) We want to remove bidfloor if not set by pb (prebid#3866) aardvark tdid support (prebid#3860) auction key limiter feature (prebid#3825) minor updates to consentManagement tests (prebid#3849) Rhythmone Adapter - Multiple ad size support, rewrite tests, update docs. (prebid#3854) Adding bidfloor to video imp req (prebid#3863) adding Outstream mediaType to EMX Digital (prebid#3840) Added optional dealId parameter to bid response. (prebid#3858) Update rtbhouseBidAdapter.md (prebid#3857) Updated the bidder code in the test ad unit. (prebid#3844) change in Aardvark adapter to handle additional data (prebid#3821) Refactor bid response - remove unnecessary properties (prebid#3807) Increment pre version Prebid 2.16.0 release fix how native sizes are passed in AppNexus adapter (prebid#3832) updated ozone adapter from v1.4.4 -> v2.0.0 (prebid#3828) Adding advertiserId to appnexus adapter (prebid#3833) ...
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jun 7, 2019
* native support & minor changes * native support & minor changes * increase test coverage * fix win price value * fix win price value tests * fix alias, fix bidfloor * remove alias * use currency.adServerCurrency * update version
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* native support & minor changes * native support & minor changes * increase test coverage * fix win price value * fix win price value tests * fix alias, fix bidfloor * remove alias * use currency.adServerCurrency * update version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
add support of currency.adServerCurrency
prebid@mgid.com