Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgid adapter: add support of currency.adServerCurrency #3850

Merged
merged 12 commits into from
May 29, 2019
Merged

mgid adapter: add support of currency.adServerCurrency #3850

merged 12 commits into from
May 29, 2019

Conversation

Gaudeamus
Copy link
Contributor

Type of change

  • Feature

Description of change

add support of currency.adServerCurrency

  • contact email of the adapter’s maintainer
    prebid@mgid.com
  • official adapter submission

@mike-chowla mike-chowla changed the title add support of currency.adServerCurrency mgid adapter: add support of currency.adServerCurrency May 27, 2019
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Maybe add a unit test in a future PR to mock config.getConfig('adServerCurrency'); and make sure the request is built exactly how you expect!

Thank you!

@robertrmartinez robertrmartinez merged commit efd5ed6 into prebid:master May 29, 2019
kd-appier added a commit to appier/Prebid.js that referenced this pull request May 30, 2019
* 'master' of https://github.com/appier/Prebid.js: (160 commits)
  Increment pre version
  Prebid 2.17.0 Release
  mgid adapter: add support of currency.adServerCurrency (prebid#3850)
  We want to remove bidfloor if not set by pb (prebid#3866)
  aardvark tdid support (prebid#3860)
  auction key limiter feature (prebid#3825)
  minor updates to consentManagement tests (prebid#3849)
  Rhythmone Adapter - Multiple ad size support, rewrite tests, update docs. (prebid#3854)
  Adding bidfloor to video imp req (prebid#3863)
  adding Outstream mediaType to EMX Digital (prebid#3840)
  Added optional dealId parameter to bid response. (prebid#3858)
  Update rtbhouseBidAdapter.md (prebid#3857)
  Updated the bidder code in the test ad unit. (prebid#3844)
  change in Aardvark adapter to handle additional data  (prebid#3821)
  Refactor bid response - remove unnecessary properties (prebid#3807)
  Increment pre version
  Prebid 2.16.0 release
  fix how native sizes are passed in AppNexus adapter (prebid#3832)
  updated ozone adapter from v1.4.4 -> v2.0.0 (prebid#3828)
  Adding advertiserId to appnexus adapter (prebid#3833)
  ...
kd-appier added a commit to appier/Prebid.js that referenced this pull request May 30, 2019
* master: (160 commits)
  Increment pre version
  Prebid 2.17.0 Release
  mgid adapter: add support of currency.adServerCurrency (prebid#3850)
  We want to remove bidfloor if not set by pb (prebid#3866)
  aardvark tdid support (prebid#3860)
  auction key limiter feature (prebid#3825)
  minor updates to consentManagement tests (prebid#3849)
  Rhythmone Adapter - Multiple ad size support, rewrite tests, update docs. (prebid#3854)
  Adding bidfloor to video imp req (prebid#3863)
  adding Outstream mediaType to EMX Digital (prebid#3840)
  Added optional dealId parameter to bid response. (prebid#3858)
  Update rtbhouseBidAdapter.md (prebid#3857)
  Updated the bidder code in the test ad unit. (prebid#3844)
  change in Aardvark adapter to handle additional data  (prebid#3821)
  Refactor bid response - remove unnecessary properties (prebid#3807)
  Increment pre version
  Prebid 2.16.0 release
  fix how native sizes are passed in AppNexus adapter (prebid#3832)
  updated ozone adapter from v1.4.4 -> v2.0.0 (prebid#3828)
  Adding advertiserId to appnexus adapter (prebid#3833)
  ...
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jun 7, 2019
* native support & minor changes

* native support & minor changes

* increase test coverage

* fix win price value

* fix win price value tests

* fix alias, fix bidfloor

* remove alias

* use currency.adServerCurrency

* update version
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* native support & minor changes

* native support & minor changes

* increase test coverage

* fix win price value

* fix win price value tests

* fix alias, fix bidfloor

* remove alias

* use currency.adServerCurrency

* update version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants