-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add beachfront bidder params to set outstream player settings #3868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jsalis ,
Thanks for submitting your adaptor. I tested your adaptor on hello-world page and found functionality working fine. Just a small change that can you add the new bidder params (that include player) to your .md file as well.
Thanks!
I added an example to the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the adaptor on hello_world page and all unit tests have passed. Test coverage of the adaptor is above 80%. The changes are working well against all parameters listed in https://github.com/prebid/Prebid.js/blob/master/PR_REVIEW.md, hence approving the PR.
…#3868) * Add beachfront bidder params to set outstream player settings * Add example for outstream player params * Run ci again
…#3868) * Add beachfront bidder params to set outstream player settings * Add example for outstream player params * Run ci again
Type of change
Description of change
Adds bidder params to pass player settings for the outstream renderer.
PR for docs:
prebid/prebid.github.io#1334