Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beachfront bidder params to set outstream player settings #3868

Merged
merged 3 commits into from
Jun 13, 2019

Conversation

jsalis
Copy link
Contributor

@jsalis jsalis commented May 29, 2019

Type of change

  • Feature
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

Adds bidder params to pass player settings for the outstream renderer.

{
  bidder: 'beachfront',
  params: {
    bidfloor: 0.01,
    appId: '11bc5dd5-7421-4dd8-c926-40fa653bec76'
    player: {
      collapseOnComplete: false
    }
  }
}

PR for docs:
prebid/prebid.github.io#1334

Copy link
Contributor

@sumit116 sumit116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsalis ,
Thanks for submitting your adaptor. I tested your adaptor on hello-world page and found functionality working fine. Just a small change that can you add the new bidder params (that include player) to your .md file as well.

Thanks!

@sumit116 sumit116 added the LGTM label Jun 11, 2019
@jsalis
Copy link
Contributor Author

jsalis commented Jun 11, 2019

I added an example to the docs.

@sumit116 sumit116 requested review from sumit116 and removed request for sumit116 June 13, 2019 12:57
Copy link
Contributor

@sumit116 sumit116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the adaptor on hello_world page and all unit tests have passed. Test coverage of the adaptor is above 80%. The changes are working well against all parameters listed in https://github.com/prebid/Prebid.js/blob/master/PR_REVIEW.md, hence approving the PR.

@sumit116 sumit116 requested a review from jsnellbaker June 13, 2019 13:46
@jsnellbaker jsnellbaker merged commit 40f032c into prebid:master Jun 13, 2019
@jsalis jsalis deleted the player-params branch July 9, 2019 13:32
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
…#3868)

* Add beachfront bidder params to set outstream player settings

* Add example for outstream player params

* Run ci again
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
…#3868)

* Add beachfront bidder params to set outstream player settings

* Add example for outstream player params

* Run ci again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants