-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Analytics Adapter: Implement Appier Analytics Adapter. #3871
New Analytics Adapter: Implement Appier Analytics Adapter. #3871
Conversation
3aa27d7
to
04209e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kd-appier
Thanks for submitting this new analytics adapter. There are a few initial points/questions I had (see comments in-line below).
Additionally, do you have a sample set of values to use for the options
config that I can use for testing?
Finally, can you please put together PR for the docs repo to add your analytics adapter so your analytics adapter will appear on the this page?
Thanks!
modules/appierAnalyticsAdapter.js
Outdated
@@ -0,0 +1,245 @@ | |||
import {ajax} from 'src/ajax'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a relative path reference for this import (like the others).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thank you~
modules/appierAnalyticsAdapter.js
Outdated
import adapterManager from '../src/adapterManager'; | ||
import {logError, logInfo} from '../src/utils'; | ||
|
||
const utils = require('../src/utils'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it appears you're only using the deepClone
function from the utils
file, could you just import that function along with the logError
and logInfo
functions above to simplify things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thank you~
if (bid.currency === 'USD') { | ||
return bid.cpm; | ||
} else { | ||
return bid.getCpmInNewCurrency('USD'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm - this property getCpmInNewCurrency
is only populated when the publisher has the currency
module activated. Are you expecting the currency
module to be active as a requirement for using your analytics adapter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, currency module is required. I have added this reminder in README.md, thank you :)
04209e9
to
4d09ddc
Compare
Thank you @jsnellbaker :) I have fixed the issues in your comments. This is the testing config:
This is our PR for the docs repo: Thank you very much :) |
@kd-appier Thanks for all the updates and the test credentials. Everything appeared to be working successfully on my end and the code changes look good. |
Cool. thank you @jsnellbaker :) |
Type of change
Description of change
New Appier Analytics Adapter to gather Prebid.js event data and forward to Appier reporting platform.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/