Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bidFloor to Yieldmo Adapter #3886

Merged
merged 10 commits into from
Jun 13, 2019
Merged

Add bidFloor to Yieldmo Adapter #3886

merged 10 commits into from
Jun 13, 2019

Conversation

HolzAndrew
Copy link
Contributor

Type of change

  • Feature

Description of change

Add Bidfloor to Yieldmo Adapter. Also changes a local variable name.

@harquail @jasminenoack @elberdev @MelodyLi2017

@HolzAndrew HolzAndrew changed the title Add Bidfloor to Yieldmo Adapter WIP: Add Bidfloor to Yieldmo Adapter Jun 5, 2019
@HolzAndrew HolzAndrew changed the title WIP: Add Bidfloor to Yieldmo Adapter Add Bidfloor to Yieldmo Adapter Jun 5, 2019
@HolzAndrew HolzAndrew changed the title Add Bidfloor to Yieldmo Adapter Add bidFloor to Yieldmo Adapter Jun 5, 2019
@bretg
Copy link
Collaborator

bretg commented Jun 10, 2019

Needs a docs PR covering:

  • addition of bidFloor param
  • support for pubCommon ID -- add "userIds: pubCommon" to the jekyll variables on top

@HolzAndrew
Copy link
Contributor Author

@bretg made pr to docs

@bretg
Copy link
Collaborator

bretg commented Jun 13, 2019

Thanks - Docs PR prebid/prebid.github.io#1350

@bretg bretg merged commit efe74f8 into prebid:master Jun 13, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* change userid to pubcid

* removes consolelogs

* removes .txt file

* fixes test

* make the if statement useful

* fix indentation

* move return back to the correct place

* fix indent
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
* change userid to pubcid

* removes consolelogs

* removes .txt file

* fixes test

* make the if statement useful

* fix indentation

* move return back to the correct place

* fix indent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants