Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GumGum: adds tradedesk id param #3896

Merged
merged 5 commits into from
Jun 20, 2019
Merged

GumGum: adds tradedesk id param #3896

merged 5 commits into from
Jun 20, 2019

Conversation

susyt
Copy link
Contributor

@susyt susyt commented Jun 12, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

This adds support for the Unified/TradeDesk id from Prebid's user id module

Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test please

@bretg bretg self-assigned this Jun 12, 2019
@jsnellbaker jsnellbaker requested a review from bretg June 20, 2019 12:47
@bretg bretg merged commit ce095e0 into prebid:master Jun 20, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
* adds tradedesk id param

* adds more tests

* removes only from test spec

* linting fix

* updates one of the unit tests
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
* adds tradedesk id param

* adds more tests

* removes only from test spec

* linting fix

* updates one of the unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants