Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

digiTrustIdSystem.js add the synchronous behavior to facade call of D… #3913

Merged

Conversation

goosemanjack
Copy link
Contributor

add the synchronous behavior to facade call of DigiTrust.getId. Fix spelling error of facade in code.

Type of change

  • [X ] Bugfix

Description of change

The initial implementation of DigiTrust Id System and the facade only implemented async behavior on the getId API. This adds in the synchronous behavior to that API as well as implemented on the facade object. Also fixed a spelling error in variable name.

  • contact email of the adapter’s maintainer
  • [x ] official adapter submission
    ccole@emination.com

Other information

Part of userId system for DigiTrust.

…igiTrust.getId. Fix spelling error of facade in code.
Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idettman idettman merged commit 842cc19 into prebid:master Jun 17, 2019
@goosemanjack goosemanjack deleted the digitrustSyncGetUser branch June 17, 2019 21:14
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
…igiTrust.getId. Fix spelling error of facade in code. (prebid#3913)
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
…igiTrust.getId. Fix spelling error of facade in code. (prebid#3913)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants