Integrate id link system #3965
Merged
Integrate id link system #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # integrationExamples/gpt/userId_example.html # test/spec/modules/userId_spec.js
# Conflicts: # modules/userId/index.js
idettman
suggested changes
Jul 9, 2019
modules/userId/index.js
Outdated
| @@ -423,5 +425,6 @@ init(config); | |||
| // add submodules after init has been called | |||
| attachIdSystem(pubCommonIdSubmodule); | |||
| attachIdSystem(unifiedIdSubmodule); | |||
| attachIdSystem(identityLinkSubmodule); | |||
There was a problem hiding this comment.
The attachIdSystem should be used in the file identityLinkSystem.js, the unifiedId and pubComonId are the only submodules included by default, and they will also be optional starting with Prebid 3.0.
Look at the code for ID5 Submodule as an example.
Specifically, lines 10 and 60 are responsible for registering the submodule with the user id module.
There was a problem hiding this comment.
Hi @idettman,
Thank you for the explanation. I'm changed implementation of identityLink submodule as you suggested. Follow the code in ID5 Submodule...
|
Also, conflicts need resolution |
idettman
added
needs 2nd review
idettman
reviewed
Jul 17, 2019
modules/userId/index.js
Outdated
| @@ -77,6 +78,7 @@ import CONSTANTS from '../../src/constants.json'; | |||
| import {module} from '../../src/hook'; | |||
| import {unifiedIdSubmodule} from './unifiedIdSystem.js'; | |||
| import {pubCommonIdSubmodule} from './pubCommonIdSystem.js'; | |||
| import {identityLinkSubmodule} from './identityLinkSystem.js'; | |||
There was a problem hiding this comment.
Remove the import for identityLinkSubmodule - the identity link submodule handles the registering in it’s submodule js.
idettman
added
LGTM
and removed
needs 2nd review
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
* idLink - integrate new submodule idLinkSystem in to userId module * idLink - Fix unit tests * identityLink - Change submodule name from idLink to identityLink * Identity Link - Remove identity link to be default submodule
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* idLink - integrate new submodule idLinkSystem in to userId module * idLink - Fix unit tests * identityLink - Change submodule name from idLink to identityLink * Identity Link - Remove identity link to be default submodule
9 tasks
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
* idLink - integrate new submodule idLinkSystem in to userId module * idLink - Fix unit tests * identityLink - Change submodule name from idLink to identityLink * Identity Link - Remove identity link to be default submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add Identity Link submodule in module userId to fetch user’s identity link envelope and add it to the bid request. It is very similar to other userId submodule like Id5id and unifiedID.
A link to a PR on the docs repo at Integrate id link system prebid.github.io#1377