Triplelift adapter tdid support #3983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@rmcnierney Code is LGTM. Can you remove package-lock.json from this PR.
|
Thanks, @jaiminpanchal27. package-lock.json should now be removed |
|
@rmcnierney Please create a docs PR to update the list here http://prebid.org/dev-docs/modules/userId.html#adapters-supporting-the-user-id-sub-modules You need to add variable |
|
@jaiminpanchal27 docs PR here - Update docs for Triplelift tdid support #1392 |
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
* Add user support in _buildPostBody * Add tdid check to test spec * Remove comments * Removing package-lock.json changes
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* Add user support in _buildPostBody * Add tdid check to test spec * Remove comments * Removing package-lock.json changes
cdsmith16
reviewed
Aug 5, 2019
| @@ -91,6 +91,13 @@ function _buildPostBody(bidRequests) { | |||
| } | |||
| }); | |||
|
|
|||
| let eids = handleConsortiaUserIds(bidderRequest) | |||
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
* Add user support in _buildPostBody * Add tdid check to test spec * Remove comments * Removing package-lock.json changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Updating the TripleLift adapter to read The Trade Desk's Unified ID -
bidRequest.userId.tdid