Revert "update karma and webpack-stream packages to address vulnerabilities" #4003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6399ab1.
jaiminpanchal27
approved these changes
Jul 16, 2019
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3966
This change is causing issues in circleci builds. Specifically, the upgraded karma package uses a spread operator as part of its logic and this operator is only available in Node 10+
https://circleci.com/gh/prebid/Prebid.js/2999
Initial attempts to fix this issue by updating the node version in circleCI (see #4001) were not completely successful as the circleci jobs for some reason fail to finish.
Temporarily reverting these package changes until we identify the outstanding issues.