Add Logicad for Publishers bid adapter #4010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
requested changes
Jul 22, 2019
There was a problem hiding this comment.
Hi @logicad
Thanks for submitting this new adapter; I ran some tests and it appears to working as expected.
I had one question regarding the userSync code, please see below when you have the chance.
Thanks!
| syncOptions.pixelEnabled && serverResponses[0].body.userSync.type == 'image') { | ||
| return [{ | ||
| type: 'image', | ||
| url: serverResponses[0].body.userSync.url |
There was a problem hiding this comment.
To confirm - if you're returning multiple bids, this code would only grab the first bid's userSync pixel. The other bids' userSync pixels would be left out.
Is that expected?
There was a problem hiding this comment.
Hi @jsnellbaker
Thank you for the review.
Yes, it is as expected.
Only using the first bids will fulfill our requirements.
jsnellbaker
approved these changes
Jul 23, 2019
leonardlabat
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Jul 30, 2019
* Add Logicad for Publishers bid adapter * Add test code
VideoReach
pushed a commit
to VideoReach/Prebid.js
that referenced
this pull request
Aug 1, 2019
* Add Logicad for Publishers bid adapter * Add test code
sa1omon
pushed a commit
to gamoshi/Prebid.js
that referenced
this pull request
Nov 28, 2019
* Add Logicad for Publishers bid adapter * Add test code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
New Logicad for Publishers bid adapter
contact email of the adapter’s maintainer: prebid@so-netmedia.jp
official adapter submission
A link to a PR on the docs repo at Logicad for Publishers bid adapter prebid.github.io#1395