Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inskin Bid Adapter - New Feature #4011

Merged
merged 4 commits into from
Jul 23, 2019
Merged

Inskin Bid Adapter - New Feature #4011

merged 4 commits into from
Jul 23, 2019

Conversation

cciocov
Copy link
Contributor

@cciocov cciocov commented Jul 19, 2019

Type of change

  • Feature

Description of change

  • Updated the way bid price is set based on the ad server response
  • Updated the impression URL
  • official adapter submission

bretg
bretg requested changes Jul 22, 2019
View reviewed changes
Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a couple of unit tests covering the pubCPM-vs-clearPrice scenario.

@bretg bretg self-assigned this Jul 22, 2019
@cciocov
Copy link
Contributor Author

cciocov commented Jul 23, 2019

@bretg I've added testing for this, thanks for the feedback.

@bretg bretg merged commit 2ceeb38 into prebid:master Jul 23, 2019
leonardlabat pushed a commit to criteo-forks/Prebid.js that referenced this pull request Jul 30, 2019
@cciocov @leonardlabat
Inskin Bid Adapter - New Feature (prebid#4011)
4dad00e 
* Add support for different publisher payment models.

* Add Inskin integration example.

* Append pubcpm to impression tracker.

* Added unit tests for pubCMP vs clearPrice.
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
@cciocov
Inskin Bid Adapter - New Feature (prebid#4011)
07c237a 
* Add support for different publisher payment models.

* Add Inskin integration example.

* Append pubcpm to impression tracker.

* Added unit tests for pubCMP vs clearPrice.
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
@cciocov
Inskin Bid Adapter - New Feature (prebid#4011)
7ba15a2 
* Add support for different publisher payment models.

* Add Inskin integration example.

* Append pubcpm to impression tracker.

* Added unit tests for pubCMP vs clearPrice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

Assignees

@bretg bretg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cciocov @bretg