Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdGeneration,Kumma,Platformio: s3 http domain migration #4012

Merged
merged 1 commit into from
Jul 22, 2019
Merged

AdGeneration,Kumma,Platformio: s3 http domain migration #4012

merged 1 commit into from
Jul 22, 2019

Conversation

sudhanshuptl
Copy link
Contributor

@sudhanshuptl sudhanshuptl commented Jul 22, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

❓ What
Updated Amazon S3 Path as the current s3 HTTP domain is getting deprecated

🔨 Test

  • Verify new s3 URL is able to fetch the data as usual.
  • Verify any functional impact

Other information

@bretg bretg changed the title SRE-1994: s3 http domain migration AdGeneration,Kumma,Platformio: s3 http domain migration Jul 22, 2019
Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes only in test files.

@bretg bretg merged commit adc1576 into prebid:master Jul 22, 2019
leonardlabat pushed a commit to criteo-forks/Prebid.js that referenced this pull request Jul 30, 2019
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants