Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to webpack 4 #4112

Closed
wants to merge 16 commits into from
Closed

upgrade to webpack 4 #4112

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ac9af99
upgrade to webpack 4
Aug 16, 2019
6b8cbd9
update chunk name
Aug 21, 2019
0cc1022
Merge branch 'master' of https://github.com/prebid/Prebid.js into RAD…
Aug 22, 2019
115031b
update splitchunks params
Aug 22, 2019
d5effd3
update packages and conf files
Aug 23, 2019
877c763
refactor
Aug 23, 2019
d5c0086
remove unused var
Aug 23, 2019
a8fd49a
Merge branch 'master' of https://github.com/prebid/Prebid.js into RAD…
Aug 29, 2019
0938b74
split chunks plugin copy
Aug 29, 2019
485bb75
refactor plugin name
Aug 29, 2019
2250d6c
update chunk params
Aug 29, 2019
93e201f
fix unit tests
Aug 29, 2019
540e14b
use splitChunks plugin with multiple file hack
snapwich Sep 12, 2019
cabfcb5
add missing gulp-filter to gulpfile
snapwich Sep 12, 2019
0569ff7
Merge remote-tracking branch 'origin/master' into RAD-2815-webpack4-u…
snapwich Sep 12, 2019
cae59ae
update lock file after merge conflict resolution
snapwich Sep 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .babelrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ module.exports = {
"ie >= 10",
"ios >= 8"
]
}
},
modules: 'commonjs' //This causes Babel to transpile ES modules into CJS modules before Webpack sees them, which prevents Webpack from creating getters, which fixes Sinon.(Ref: https://github.com/webpack/webpack/issues/6979)
}
]
],
Expand Down
3 changes: 1 addition & 2 deletions karma.conf.maker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ function newWebpackConfig(codeCoverage) {
var webpackConfig = _.cloneDeep(webpackConf);

// remove optimize plugin for tests
webpackConfig.plugins.pop()

webpackConfig.optimization = {};
webpackConfig.devtool = 'inline-source-map';

if (codeCoverage) {
Expand Down
Loading