Fix data transmission issues on AdYouLike bid adapter #4296
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hi @GLStephen the requested changes have been made. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hi @GLStephen the requested changes have been made. |
|
LGTM |
|
@guiann it looks like conflicts have appeared from master. resolve them and I'll recheck. |
|
master merged, conflict resolved. thx |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Can we have the information on when this will be merged please ? |
* Remove useless bidderCode in bid response * send all the available sizes in the bid request * Use the banner sizes if given * avoid compatibility issue with old bid format * remove duplicate call to encodeUriComponent * add unit test on refererUrl and mediatype banner size * minor: fix lint error on spec file * if size is empty read the requested width or height * add unit tests on multipe ad placement with several sizes * add check on bidRequest object in case of error state
Type of change
Description of change
Avoid data transition issues : Referrer url was encoded twice and some errors occurs with wrong size values.