Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criteo decrease bid adapter size #4518

Merged
merged 11 commits into from
Dec 16, 2019
Merged

Criteo decrease bid adapter size #4518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fdc068a
use own package instead of npm dependencies
Oct 10, 2019
df02c46
remove eval call, use utils.insertElement instead
Oct 11, 2019
714af4c
use own package instead of npm dependencies
Oct 10, 2019
b36972b
remove eval call, use utils.insertElement instead
Oct 11, 2019
23ce146
fixed some merge issues after rebasing
leonardlabat Nov 15, 2019
525e86d
Merge branch 'criteo-decrease-bid-adapter-size' of https://github.com…
leonardlabat Nov 15, 2019
e1b38f6
switched rsa validation package to criteo's official one
leonardlabat Nov 29, 2019
5fb81e4
increment adapter version
leonardlabat Nov 29, 2019
bc40236
removed unused querystringify references (probably here after a merge…
leonardlabat Nov 29, 2019
0e2486c
updated package-lock.json
leonardlabat Nov 29, 2019
a317cef
Merge branch 'master' into criteo-decrease-bid-adapter-size
leonardlabat Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions allowedModules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const sharedWhiteList = [
module.exports = {
'modules': [
...sharedWhiteList,
'criteo-direct-rsa-validate',
'jsencrypt',
'crypto-js'
],
Expand Down
55 changes: 24 additions & 31 deletions modules/criteoBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,9 @@ import { BANNER, VIDEO } from '../src/mediaTypes';
import { parse } from '../src/url';
import * as utils from '../src/utils';
import find from 'core-js/library/fn/array/find';
import JSEncrypt from 'jsencrypt/bin/jsencrypt';
import sha256 from 'crypto-js/sha256';
import { verify } from 'criteo-direct-rsa-validate/build/verify';

export const ADAPTER_VERSION = 23;
export const ADAPTER_VERSION = 24;
const BIDDER_CODE = 'criteo';
const CDB_ENDPOINT = 'https://bidder.criteo.com/cdb';
const CRITEO_VENDOR_ID = 91;
Expand All @@ -18,12 +17,8 @@ export const PROFILE_ID_PUBLISHERTAG = 185;
// Unminified source code can be found in: https://github.com/Prebid-org/prebid-js-external-js-criteo/blob/master/dist/prod.js
const PUBLISHER_TAG_URL = '//static.criteo.net/js/ld/publishertag.prebid.js';

export const FAST_BID_PUBKEY = `-----BEGIN PUBLIC KEY-----
MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDO1BjAITkFTtP0IMzmF7qsqhpu
y1dGaTPHnjMU9mRZsrnfR3C0sEN5pYEzEcFRPnkJjJuhH8Rnh5+CE+LcKg0Z8ZZ7
OmOSj0/qnYTAYCu0cR5LiyWG79KlIgUyMbp92ulGg24gAyGrVn4+v/4c53WlOEUp
4YWvb82G0CD5NcDNpQIDAQAB
-----END PUBLIC KEY-----`;
const FAST_BID_PUBKEY_E = 65537;
const FAST_BID_PUBKEY_N = 'ztQYwCE5BU7T9CDM5he6rKoabstXRmkzx54zFPZkWbK530dwtLBDeaWBMxHBUT55CYyboR/EZ4efghPi3CoNGfGWezpjko9P6p2EwGArtHEeS4slhu/SpSIFMjG6fdrpRoNuIAMhq1Z+Pr/+HOd1pThFKeGFr2/NhtAg+TXAzaU=';

/** @type {BidderSpec} */
export const spec = {
Expand Down Expand Up @@ -121,7 +116,7 @@ export const spec = {
width: slot.width,
height: slot.height,
dealId: slot.dealCode,
}
};
if (slot.native) {
bid.ad = createNativeAd(bidId, slot.native, bidRequest.params.nativeCallback);
} else if (slot.video) {
Expand Down Expand Up @@ -198,7 +193,7 @@ function buildContext(bidRequests, bidderRequest) {
if (bidRequest.params.integrationMode === 'amp') {
context.amp = true;
}
})
});

return context;
}
Expand Down Expand Up @@ -366,27 +361,24 @@ function hasValidVideoMediaType(bidRequest) {
*/
function createNativeAd(id, payload, callback) {
// Store the callback and payload in a global object to be later accessed from the creative
window.criteo_prebid_native_slots = window.criteo_prebid_native_slots || {};
window.criteo_prebid_native_slots[id] = { callback, payload };
var slotsName = 'criteo_prebid_native_slots';
window[slotsName] = window[slotsName] || {};
window[slotsName][id] = { callback, payload };

// The creative is in an iframe so we have to get the callback and payload
// from the parent window (doesn't work with safeframes)
return `<script type="text/javascript">
var win = window;
for (var i = 0; i < 10; ++i) {
win = win.parent;
if (win.criteo_prebid_native_slots) {
var responseSlot = win.criteo_prebid_native_slots["${id}"];
responseSlot.callback(responseSlot.payload);
break;
}
}
</script>`;
return `
<script type="text/javascript">
for (var i = 0; i < 10; ++i) {
var slots = window.parent.${slotsName};
if(!slots){continue;}
var responseSlot = slots["${id}"];
responseSlot.callback(responseSlot.payload);
break;
}
</script>`;
}

/**
* @return {boolean}
*/
export function tryGetCriteoFastBid() {
try {
const fastBidStorageKey = 'criteo_fast_bid';
Expand All @@ -406,11 +398,12 @@ export function tryGetCriteoFastBid() {
const publisherTagHash = firstLine.substr(hashPrefix.length);
const publisherTag = fastBidFromStorage.substr(firstLineEndPosition + 1);

var jsEncrypt = new JSEncrypt();
jsEncrypt.setPublicKey(FAST_BID_PUBKEY);
if (jsEncrypt.verify(publisherTag, publisherTagHash, sha256)) {
if (verify(publisherTag, publisherTagHash, FAST_BID_PUBKEY_N, FAST_BID_PUBKEY_E)) {
utils.logInfo('Using Criteo FastBid');
eval(publisherTag); // eslint-disable-line no-eval
const script = document.createElement('script');
script.type = 'text/javascript';
script.text = publisherTag;
utils.insertElement(script);
} else {
utils.logWarn('Invalid Criteo FastBid found');
localStorage.removeItem(fastBidStorageKey);
Expand Down
Loading