-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added TPMN Bidder Adapter #4547
Conversation
Hi, I would like to mention that in our local testing environment there are no issues with gulp test-coverage error pulling on CircleCI. Please let me know if there is a proper way to resolve the issue, or any concern is appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tpmn
Thanks for submitting this new adapter. Overall the code here looks good.
There are a few items that should be reviewed/addressed. Can you please take a look at the in-line comments (and the item below) and make the requested changes?
In the response headers, I observed that there was no content-encoding to compress the data (such as using gzip). This is a recommended setting to ensure the responses are optimal. Can you implement this type of setting in your response?
Hi @jsnellbaker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tpmn Thanks for making the updates here and on the server-end.
LGTM
* implement TPMN Bidder Adapter * fixed bug for failed test on CircleCl--added line * removed comment line for 'config' * added https protocol
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
develop@tpmn.co.kr
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Added TPMN Markdown prebid.github.io#1651
Other information