Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added TPMN Bidder Adapter #4547

Merged
merged 4 commits into from
Dec 12, 2019
Merged

added TPMN Bidder Adapter #4547

merged 4 commits into from
Dec 12, 2019

Conversation

tpmn-admin
Copy link
Contributor

@tpmn-admin tpmn-admin commented Dec 6, 2019

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: 'tpmn',
  params: {
    inventoryId: '1',
    publisherId: 'TPMN'
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
    develop@tpmn.co.kr
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@jsnellbaker jsnellbaker self-requested a review December 6, 2019 15:56
@jsnellbaker jsnellbaker self-assigned this Dec 6, 2019
@tpmn-admin
Copy link
Contributor Author

Hi, I would like to mention that in our local testing environment there are no issues with gulp test-coverage error pulling on CircleCI. Please let me know if there is a proper way to resolve the issue, or any concern is appreciated!

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tpmn

Thanks for submitting this new adapter. Overall the code here looks good.

There are a few items that should be reviewed/addressed. Can you please take a look at the in-line comments (and the item below) and make the requested changes?

In the response headers, I observed that there was no content-encoding to compress the data (such as using gzip). This is a recommended setting to ensure the responses are optimal. Can you implement this type of setting in your response?

modules/tpmnBidAdapter.js Outdated Show resolved Hide resolved
modules/tpmnBidAdapter.js Outdated Show resolved Hide resolved
@tpmn-admin
Copy link
Contributor Author

In the response headers, I observed that there was no content-encoding to compress the data (such as using gzip). This is a recommended setting to ensure the responses are optimal. Can you implement this type of setting in your response?

Hi @jsnellbaker
Thanks for the quick review. for the responses, we have implemented gzip compression for every response and can be obtained from the server. Please let us know if there's any further issue with the code. Thanks!

@tpmn-admin tpmn-admin changed the title add TPMN Bidder Adapter added TPMN Bidder Adapter Dec 11, 2019
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tpmn Thanks for making the updates here and on the server-end.

LGTM

@jsnellbaker jsnellbaker merged commit b615862 into prebid:master Dec 12, 2019
tadam75 pushed a commit to smartadserver/Prebid.js that referenced this pull request Jan 9, 2020
* implement TPMN Bidder Adapter

* fixed bug for failed test on CircleCl--added line

* removed comment line for 'config'

* added https protocol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants