Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onevideo supporting both CCPA and GDPR present case #4571

Merged
merged 39 commits into from
Dec 14, 2019

Conversation

DeepthiNeeladri
Copy link
Contributor

Type of change

  • [X ] Bugfix

Description of change

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@lgtm-com
Copy link

lgtm-com bot commented Dec 11, 2019

This pull request introduces 2 alerts when merging 4a744c0 into 8c4039b - view on LGTM.com

new alerts:

  • 2 for Unneeded defensive code

@bretg
Copy link
Collaborator

bretg commented Dec 11, 2019

please add/modify unit test(s)

@DeepthiNeeladri
Copy link
Contributor Author

@bretg added test cases, all are passing in my local but ci/circleci is failing with error "Build was canceled"

@jsnellbaker
Copy link
Collaborator

@DeepthiNeeladri We're having some issues (for some reason) with browserstack keeping the browser sessions connected. I tried to cancel the build since it was just restarting the sessions in a loop. Trying to run it again.

@DeepthiNeeladri
Copy link
Contributor Author

@bretg @jsnellbaker review pls

usp: {
cmpApi: 'iab',
timeout: 1000,
allowAuctionWithoutConsent: 'cancel'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the record, usp doesn't support the allowAuctionWithoutConsent parameter

@bretg
Copy link
Collaborator

bretg commented Dec 14, 2019

Will go ahead and merge this, but note that you'll probably want to add a docs PR so you show as one of the adapters supporting CCPA. Set the usp_supported flag on https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/oneVideo.md

@bretg bretg merged commit dcb4d6b into prebid:master Dec 14, 2019
@bretg
Copy link
Collaborator

bretg commented Dec 14, 2019

Also note -- so far it's only merged into 3.1. If you want CCPA supported in the 2.x branch please open another PR against the 2.44.x-legacy branch

tadam75 pushed a commit to smartadserver/Prebid.js that referenced this pull request Jan 9, 2020
* outstream changes

* removing global filtet

* reverting page

* message

* adapter change

* remove space

* testcases

* testpage

* spaces for test page

* renderer exist case

* reverting package-lock.json

* adding schain object

* adding tagid

* syntaxx error fix

* video.html

* space trailing

* space

* tagid

* inventoryId and placement

* rewarded video

* added unit test case

* ccpa cahnges

* ccpa change

* test page

* test page change

* test page change 2

* change the variable

* handling the case if both GDPR and CCPA case

* handiling both cases

* test cases
@DeepthiNeeladri DeepthiNeeladri deleted the onevideo_ccpa_gdpr_support branch January 17, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants