Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GumGum: adds us privacy (CCPA) support #4581

Merged
merged 2 commits into from
Jan 2, 2020
Merged

GumGum: adds us privacy (CCPA) support #4581

merged 2 commits into from
Jan 2, 2020

Conversation

susyt
Copy link
Contributor

@susyt susyt commented Dec 11, 2019

#3923 Type of change

  • Feature

Description of change

adds support for us privacy/ccpa in adapter

Other information

cc @derberbaby @WayneYang1

@bretg
Copy link
Collaborator

bretg commented Dec 11, 2019

docs pr prebid/prebid.github.io#1673

harpere
harpere reviewed Dec 12, 2019
View reviewed changes
modules/gumgumBidAdapter.js
@@ -198,6 +199,9 @@ function buildRequests (validBidRequests, bidderRequest) {
if (data.gdprApplies) {
data.gdprConsent = gdprConsent.consentString;
}
if (uspConsent) {
data.uspConsent = uspConsent;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the param should be us_privacy

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, although the IAB spec for USP/CCPA suggests us_privacy as the industry standard, you're not required to use that parameter for your endpoint.

harpere
harpere requested changes Dec 12, 2019
View reviewed changes
Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect param and should also add consent to user sync request

@harpere
Copy link
Collaborator

harpere commented Dec 12, 2019

docs: https://github.com/prebid/prebid.github.io/pull/1673/files

@harpere harpere self-assigned this Dec 12, 2019
@susyt
Copy link
Contributor Author

susyt commented Dec 12, 2019

hey @harpere
are you referring to the getUserSyncs method? If so, GumGum's ad server returns the userSync pixels with the consent appended - no change is needed
As for the incorrect param, it's been requested by our internal team to name the us privacy consent parameter as uspConsent - is it a hard requirement to name it us_privacy?

@susyt
Copy link
Contributor Author

susyt commented Dec 26, 2019

hi @harpere & @bretg ,
is there anything else holding this PR back from approval?

@harpere
Copy link
Collaborator

harpere commented Jan 2, 2020

no, the param name is not a hard requirement.

@harpere
Copy link
Collaborator

harpere commented Jan 2, 2020

yes, referring to the getUserSyncs() method. OK if it's already appended.

@harpere harpere merged commit 773a004 into prebid:master Jan 2, 2020
redaguermas added a commit to redaguermas/Prebid.js that referenced this pull request Jan 8, 2020
@redaguermas
Merge branch 'master' of https://github.com/prebid/Prebid.js into Nob…
cb7a68d 
…idVersion1.2.0

* 'master' of https://github.com/prebid/Prebid.js: (22 commits)
  fix lint errors in unit test file (prebid#4702)
  Add Revcontent Adapter (prebid#4654)
  Changed data structure in Platform One Analytic Adapter (prebid#4647)
  increment pre version
  Prebid 3.2.0 Release
  Add static API option to the consentManagementUsp module. (prebid#4685)
  replace all xhr stubs with global xhr stub to prevent all requests (prebid#4687)
  Add CCPA us_privacy support to spotxBidAdapter (prebid#4689)
  ucfunnel adapter support CCPA and remove utils.js in adapter (prebid#4541)
  freewheelSSPBidAdapter  (prebid#4645)
  Add CCPA support to Beachfront adapter (prebid#4673)
  add seedingAlliance Adapter (prebid#4614)
  Changed analytics data structure in YuktaMedia Analytic Adapter (prebid#4659)
  Add eplanning adapter for prebid 3.0 compliant and CCPA and GDPR support (prebid#4643)
  Bidder schain support (prebid#4551)
  Added CCPA support and GDPR compliance to Cedato adapter (prebid#4683)
  pass us privacy consent string to request (prebid#4581)
  Prebid 3 Admixer (prebid#4615)
  Pass uspConsent in bidRequest (prebid#4675)
  Advertly: New Bidder Adapter Submission (prebid#4496)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harpere harpere harpere requested changes

Assignees

@harpere harpere

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@susyt @bretg @harpere