New adfinity adapter #4591

adfinity-prebid · 2019-12-13T10:06:38Z

Type of change

New bidder adapter

test parameters for validating bids

{
  bidder: 'afinity',
                        params: {
                            placement_id: 0,
                            traffic: 'banner'
                        }
}

contact email of the adapter’s maintainer
adfinity_prebid@i.ua
official adapter submission
A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/
New Adfinity adpter prebid.github.io#1684

jsnellbaker

Hi @adfinity-prebid

Thanks for submitting this adapter. Overall everything seems okay, there are a few points that need to be addressed.

It seems that the response (for the test banner at least) was not gzip encoded. Can you please make this update?
Are there any sample test params for video and native? If you're going to support these formats, I'd like to test them out through the adapter to ensure the end-to-end workflow is working as expected.

Thanks!

jsnellbaker · 2019-12-18T15:53:01Z

modules/adfinityBidAdapter.md

+                    }
+                },
+                bids: [{
+                        bidder: 'afinity',


small typo in the bidder name here. Should be adfinity as per the BIDDER_CODE in the .js file.

I've added test params for video and native into .md file. For testing just change traffic type.
About gzip, is this mandatory in current release?

Thanks for updating the test params, I'll take a look.

The compression of the response is required; this can be done with gzip or other similar settings in the content-encoding param (such as deflate or compress, if those are more preferable).

jsnellbaker

Hi @adfinity-prebid

I ran some tests on the video and native params and have some additional feedback. Can you take a look when you get the chance?

jsnellbaker · 2019-12-19T19:53:31Z

modules/adfinityBidAdapter.md

+                        }
+                    },
+                    {
+                        bidder: 'afinity',


Looks like the typo cropped up again. :) Can you update these two references?

jsnellbaker · 2019-12-19T19:53:38Z

modules/adfinityBidAdapter.md

+                        }
+                    },
+                    {
+                        bidder: 'afinity',


jsnellbaker · 2019-12-19T20:01:02Z

modules/adfinityBidAdapter.md

+                    {
+                        bidder: 'afinity',
+                        params: {
+                            placement_id: 0,
+                            traffic: 'video'
+                        }
+                    },
+                    {
+                        bidder: 'afinity',
+                        params: {
+                            placement_id: 0,
+                            traffic: 'native'
+                        }
+                    }


Can you restructure these test params into separate adUnits with their own mediaTypes? I assume you're supporting instream video only? I can't really confirm.

The same applies to native, in terms of which assets you support.

jsnellbaker · 2019-12-19T20:04:31Z

modules/adfinityBidAdapter.js

+        let resItem = serverResponse[i];
+        if (isBidResponseValid(resItem)) {
+          response.push(resItem);
+        }


This current code doesn't really support native bids, at least based on the test native params that were provided.

When creating a native bid for Prebid, there are certain fields that need to be defined to properly identify all the normal native assets (which are used in the rendering process). Can you update the logic here to add this support?

The following page provides some additional information if needed:
http://prebid.org/dev-docs/bidder-adaptor.html#supporting-native

Ok, help me to understend, what prebid adapter shoukd get in response from SSP, currently, using test params we return such object
{ mediaType: 'native', native:{ clickUrl: "", title: 'Test', image: { url: '', width: 226, height: 158 }, impressionTrackers: [] }, ttl: 120, cpm: 0.4, requestId: placement['bidId'], creativeId: '2', netRevenue: true, currency: 'USD', dealId: '1' }
This response contains minimal data to render native ad: clickUrl, impTrackers, image and title. This should be enough to test integration. To apply assets, our users stores them into ssp user UI

So on the whole, that list you provided should be sufficient in the minimal terms. If you're not going to add the code in the adapter to set the values for the bidResponse, you'll have to ensure any other potential native assets that may be used are setup properly in the SSP response that your endpoint returns.

If the values aren't formatted correctly, there's a chance that Prebid will reject that native bid as not being setup properly. Please let me know if that makes sense.

Building response to Prebid adapter on backend side i'm using construction to set prebid assets
like this:
if (asset.data) { switch (asset.data.type) { case 1: hbResponse.sponsoredBy = asset.data.value; break; case 2: hbResponse.body = asset.data.value; break; case 3: hbResponse.rating = asset.data.value; break; case 4: hbResponse.likes = asset.data.value; break; case 5: hbResponse.downloads = asset.data.value; break; case 6: hbResponse.price = asset.data.value; break; case 7: hbResponse.salePrice = asset.data.value; break; case 8: hbResponse.phone = asset.data.value; break; case 9: hbResponse.address = asset.data.value; break; case 10: hbResponse.body2 = asset.data.value; break; case 11: hbResponse.displayUrl = asset.data.value; break; case 12: hbResponse.cta = asset.data.value; break; default: hbResponse.body = asset.data.value; } } else if (asset.img) { switch (asset.img.type) { case 2: hbResponse.icon = { url: asset.img.url, width: asset.img.w, height: asset.img.h }; break; case 3: hbResponse.image = { url: asset.img.url, width: asset.img.w, height: asset.img.h }; break; default: hbResponse.image = { url: asset.img.url, width: asset.img.w, height: asset.img.h }; } }

jsnellbaker · 2020-01-06T17:45:54Z

Hi @adfinity-prebid
When you get the chance, can you take a look at the unit tests and ensure they're setup correctly? There's one that's failing for me atm when I try to run the tests when I checkout this PR locally.

Below is a copy of the error for reference:

AdfinityAdapter
    buildRequests
      ✗ Returns valid data if array of bids is valid
	expected false to be a number or a date
	Error
	   at AssertionError (webpack:///node_modules/assertion-error/index.js:74 <- test/test_index.js:40669:7)
	   at Anonymous function (webpack:///node_modules/chai/lib/chai/core/assertions.js:1584 <- test/test_index.js:50965:7)
	   at methodWrapper (webpack:///node_modules/chai/lib/chai/utils/addMethod.js:57 <- test/test_index.js:48481:5)
	   at Anonymous function (webpack:///test/spec/modules/adfinityBidAdapter_spec.js:81:6 <- test/test_index.js:70440:7)

adfinity-prebid · 2020-01-08T08:41:06Z

Thanks, i've fixed this one. For soe reason, whe i'm running gulp test localy - outpu show only this
`[10:31:45] Using gulpfile /commonuser/Documents/ADFINITYPrebid/gulpfile.js
[10:31:45] Starting 'test'...
[10:31:45] Starting 'clean'...
[10:31:45] Finished 'clean' after 42 ms
[10:31:45] Starting 'lint'...
[10:32:06]
/commonuser/Documents/ADFINITYPrebid/modules/criteoBidAdapter.js
8:1 error import "criteo-direct-rsa-validate/build/verify" cannot be resolved prebid/validate-imports

✖ 1 problem (1 error, 0 warnings)

[10:32:06] 'lint' errored after 21 s
[10:32:06] ESLintError in plugin "gulp-eslint"
Message:
Failed with 1 error
Details:
domainEmitter: [object Object]
domain: [object Object]
domainThrown: false

[10:32:06] 'test' errored after 21 s`

jsnellbaker · 2020-01-08T15:41:06Z

@adfinity-prebid You may want to try and reinstall the npm packages for your local copy of prebid.js. It looks like the package is missing. Can you give this a try?

adfinity-prebid · 2020-01-09T08:15:58Z

Yep, this worked. For now output looks good
[10:14:53] Using gulpfile ~/Documents/ADFINITYPrebid/gulpfile.js
[10:14:53] Starting 'test'...
[10:14:53] Starting 'clean'...
[10:14:53] Finished 'clean' after 35 ms
[10:14:53] Starting 'lint'...
[10:15:13] Finished 'lint' after 20 s
[10:15:13] Starting 'test'...

START:
ℹ ｢wdm｣:
ℹ ｢wdm｣: Compiled successfully.
ℹ ｢wdm｣: Compiling...
ℹ ｢wdm｣:
ℹ ｢wdm｣: Compiled successfully.
09 01 2020 10:15:49.408:INFO [karma-server]: Karma v3.1.4 server started at http://0.0.0.0:9876/
09 01 2020 10:15:49.433:INFO [launcher]: Launching browsers ChromeHeadless with concurrency unlimited
09 01 2020 10:15:49.463:INFO [launcher]: Starting browser ChromeHeadless
09 01 2020 10:15:51.248:INFO [HeadlessChrome 79.0.3945 (Linux 0.0.0)]: Connected on socket vtgGq_ORparbtM5pAAAA with id 38590072
09 01 2020 10:15:52.526:WARN [web-server]: 404: /vuble_renderer.js
09 01 2020 10:15:54.662:WARN [web-server]: 404: /nurl&s=0.66
09 01 2020 10:15:54.663:WARN [web-server]: 404: /burl&s=0.66
09 01 2020 10:15:55.291:WARN [web-server]: 404: /scriptUrl.com
LOG: 'entrance', '15:55'

Finished in 5.805 secs / 3.195 secs @ 10:15:58 GMT+0200 (Eastern European Standard Time)

SUMMARY:
✔ 3768 tests completed
ℹ 2 tests skipped
[10:15:58] Finished 'test' after 45 s
[10:15:58] Finished 'test' after 1.08 min

jsnellbaker

@adfinity-prebid
Thanks for the update. LGTM

…idVersion1.2.0 * 'master' of https://github.com/prebid/Prebid.js: New adfinity adapter (prebid#4591) add segmento bid adapter (prebid#4660) ozone 2.2.0 adapter updates (prebid#4676)

* New adfinity adapter * Update adfinityBidAdapter.md * add test params * native response validattion * fix secure param Co-authored-by: Check your git settings! <chris@chris-laptop>

New adfinity adapter

2daf661

mkendall07 requested a review from jsnellbaker December 17, 2019 19:08

mkendall07 assigned mkendall07 and jsnellbaker and unassigned mkendall07 Dec 17, 2019

fix conflict

9998f11

jsnellbaker requested changes Dec 18, 2019

View reviewed changes

jsnellbaker added the needs update label Dec 18, 2019

adfinity-prebid and others added 3 commits December 19, 2019 12:27

Update adfinityBidAdapter.md

db80f43

add test params

a2ad6bd

Merge branch 'master' of github.com:adfinity-prebid/Prebid.js

3af04d3

jsnellbaker requested changes Dec 19, 2019

View reviewed changes

native response validattion

91f6da5

fix secure param

2f56be9

jsnellbaker added LGTM and removed needs update labels Jan 9, 2020

jsnellbaker approved these changes Jan 9, 2020

View reviewed changes

jsnellbaker merged commit f7f79c3 into prebid:master Jan 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New adfinity adapter #4591

New adfinity adapter #4591

adfinity-prebid commented Dec 13, 2019

jsnellbaker left a comment

jsnellbaker Dec 18, 2019

adfinity-prebid Dec 19, 2019

jsnellbaker Dec 19, 2019

jsnellbaker left a comment

jsnellbaker Dec 19, 2019

jsnellbaker Dec 19, 2019

jsnellbaker Dec 19, 2019

jsnellbaker Dec 19, 2019

adfinity-prebid Dec 26, 2019

jsnellbaker Jan 2, 2020

adfinity-prebid Jan 3, 2020

jsnellbaker commented Jan 6, 2020

adfinity-prebid commented Jan 8, 2020

jsnellbaker commented Jan 8, 2020

adfinity-prebid commented Jan 9, 2020

jsnellbaker left a comment

New adfinity adapter #4591

New adfinity adapter #4591

Conversation

adfinity-prebid commented Dec 13, 2019

Type of change

jsnellbaker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsnellbaker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsnellbaker commented Jan 6, 2020

adfinity-prebid commented Jan 8, 2020

jsnellbaker commented Jan 8, 2020

adfinity-prebid commented Jan 9, 2020

jsnellbaker left a comment

Choose a reason for hiding this comment