Improvements for browsi RTD provider

[omerDotan]

Type of change

• Bugfix
• Other

Description of change

1. Improvements for browsi RTD provider (support for placement id macros, timeout for ajax request)
2. Change bidsBackCallback hook data (adUnits instead of adUnits codes)
3. Add timeout param (used when we don't need auction dealy)

[omerDotan]

updated docs pull request -
prebid/prebid.github.io#1690

[jsnellbaker]

Hi @omerBrowsi
When you have the chance, can you take a look at the comment below?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[bretg]

Admittedly I didn't do as much digging as I should have, but seems like this item would have affected more places. Can you please provide a bit of background for why this change is proposed?

Change bidsBackCallback hook data (adUnits instead of adUnits codes)

[jsnellbaker]

@omerBrowsi When you have the chance, can you resolve the conflicts here?

[omerDotan]

@jsnellbaker
we prefer not using the loadExternalScriptfunction
we need to set attributes and objects on our script and the function doesn't support it

@snapwich - the code was changed by you, is it critical that we use loadExternalScript?
if so, we will need to adjust this function
(code was changed on this pull request - #4687)

[snapwich]

@omerBrowsi yes it is required; your module was one of many that were making live requests during runs of the test suite in CI; that's not ideal for obvious reasons. Rather than verify everyone is properly stubbing it's much easier for us to just mandate use of the loadExternalScript when you load an external script (something that should happen rarely to begin with) and have loadExternalScript stub.

How do you need to adjust the function? I did make changes in my pull-request to accommodate your use-case: loadExternalScript now returns the script tag which can then be modified however you would like.

[omerDotan]

@snapwich @jsnellbaker @bretg
changed to use loadExternalScript
I didn't make any changes to loadExternalScript function, we will handle the difference on our side.
Update the macro to support new configs on our side

[omerDotan]

@bretg @jsnellbaker any update on this? do you need anything from me?

[jsnellbaker]

Hi @omerBrowsi

I took another look again at the changes, and I think overall things look okay. There were two items I found that would need some feedback/update.

Can you please take a look at these items when you have the chance?

Thanks.

[omerDotan]

@bretg @jsnellbaker Thanks!
@bretg the real-time data (and browsi) module does not appear on the download page, is there anything we need to do on our side?