Scaleable Analytics Adapter: Grouping Server Calls #4634
Conversation
…19_scaleable_analytics_adapter_updates
|
Tests work fine on my local machine. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@mkendall07 Just putting a message since it was marked as stale. |
…19_scaleable_analytics_adapter_updates
|
@mkendall07 I merged in new master to bring in the XHR changes which allow for tests to work. The current failing test is a different adapter failing the linting. |
|
@cconnors1515 |
…19_scaleable_analytics_adapter_updates
|
@mkendall07 Should be good to go now! I needed to add a local polyfill for Object.entries in order to pass tests on IE11. This probably should be added as an issue as local tests pass fine. |
|
@mkendall07 Can you add the need 2nd review label (if its needed) when you get a chance? Hoping to get this in for next release. Thanks! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@mkendall07 @jsnellbaker Am I able to get this pushed to master? Thank You |
There was a problem hiding this comment.
These changes LGTM.
@mkendall07 any further concerns on your end?
|
@jsnellbaker Thanks for the approval! |
Type of change
Description of change
Grouping all adunits together into a single call up to the server. This occurs once for auctions initiated and another time for bids/timeouts. Wins are still sent to server individually.
Also added a placeholder bidder for auction inits for each adunits to help differentiate requests for an adunit and requests for each bidder.