Aardvark: schain support #4636
Merged
Aardvark: schain support #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
requested changes
Jan 2, 2020
There was a problem hiding this comment.
Overall the code changes here look good. There are a few lint errors though (you can check the CircleCI job in this PR for the details).
Can you please correct these errors? To help - you should be able to run gulp lint in your terminal to have the proper fixes made for you.
In addition you may also want to submit a docs PR to update your bidders file (in this folder) to show you support schain. You just need to add schain_supported: true to the top of your file (near the other variables).
FilipStamenkovic
force-pushed
the
aardvark_schain
branch
from
77bd9ab
to
2b2748d
Compare
|
Hi @jsnellbaker, I've fixed lint errors and I've opened PR for documentation: |
jsnellbaker
approved these changes
Jan 8, 2020
There was a problem hiding this comment.
@FilipStamenkovic
Thanks for making the updates and the other PR.
LGTM
redaguermas
added a commit
to redaguermas/Prebid.js
that referenced
this pull request
Jan 9, 2020
…idVersion1.2.0 * 'master' of https://github.com/prebid/Prebid.js: upgrade gammassp to version 3.0 (prebid#4668) Aardvark: schain support (prebid#4636)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add support for SupplyChain (schain) in aardvark bid adapter.
Serialize schain object into string and pass it as a query parameter to aardvark bidder.