GDPR and unique request

[vincentproxistore]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

Make the adapter gdpr compliant and send a unique request to our server.
I had a previous previous PR but I had issues with circle ci. You can close it.

• contact email of the adapter’s maintainer
  vincent.descamps@proxistore.com

[jsnellbaker]

@vincentproxistore In regards to your comment about closing an older PR, are you referring to the #4567 PR? Please confirm.

In addition for this PR - can you please try to remove/undo the package-lock.json changes?

[jsnellbaker]

@vincentproxistore That commit you pushed deletes the package-lock.json file from the project, which isn't ideal since we want to keep it in the project.

Can you checkout a copy of the file from master and push it into this PR? It'll keep the file in the same state when the PR is merged, so there shouldn't be a real net difference to the file.

[jsnellbaker]

@vincentproxistore When I tried to test the adapter with these updates using the test params in the md file, I encountered a 400 Bad Request response from the server.

Below is a copy of the request that was executed:

{"bidId":["2127b9f0b8e6af"],"auctionId":"e447c763-63ed-4a38-98f3-7f888498555f","transactionId":"75ddd1c3-f216-481d-97f3-6b7f7572efed","sizes":[{"width":[300,250],"height":[300,600]}],"website":"example.com","language":"fr","gdpr":{"applies":false}}

The raw response was huge (around 17k characters) due to the thread stack that was included in the response payload. I copied the value from the message field however for reference:

Bad Request: Could not read JSON document: Can not deserialize instance of java.lang.String out of START_ARRAY token↵ at [Source: java.io.PushbackInputStream@2172082d; line: 1, column: 10] (through reference chain: com.proxistore.advertisement.v3.dto.BidRequestDto["bidId"]); nested exception is com.fasterxml.jackson.databind.JsonMappingException: Can not deserialize instance of java.lang.String out of START_ARRAY token↵ at [Source: java.io.PushbackInputStream@2172082d; line: 1, column: 10] (through reference chain: com.proxistore.advertisement.v3.dto.BidRequestDto["bidId"])

If you want me to include the whole raw response, please let me know. Can you please take a look at the error?

[jsnellbaker]

Hi @vincentproxistore
I tried to rerun the test again, however now I'm seeing the following errors from the endpoint:

OPTIONS http://abs.proxistore.com/fr/v3/rtb/prebid 502 (Bad Gateway)

Access to XMLHttpRequest at 'http://abs.proxistore.com/fr/v3/rtb/prebid' from origin 'http://test.localhost:9999' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.

Would you be able to take a look at these errors and correct them? If there's something on my end that I need to adjust, please let me know. Thanks.

[jsnellbaker]

@vincentproxistore

When you have the chance, please take a look at the comment below. I am seeing bids return now, but there is something that needs to be addressed.

Please let me know if you have any questions. Thanks!

[jsnellbaker]

Hi @vincentproxistore
When I was retesting the adapter, I ran our browserstack tests locally and found an issue with this flatMap function. It is not supported by IE or Edge.

If you want to continue to use this function, you'll need to add a polyfill. There appears to be one in core-js; should be able to import it from core-js/library/fn/array/flat-map. Otherwise you need to implement another form of logic that's browser compatible.

[jsnellbaker]

Thanks for making the additional update. LGTM