Code

Module - Size Mapping V2#4690

Code

Merged

Fawke merged 45 commits intomasterprebid/Prebid.js:masterfrom module-sizeMappingV2prebid/Prebid.js:module-sizeMappingV2Copy head branch name to clipboardMar 11, 2020

+2,315-44

Commits

Commits on Nov 25, 2019

• implement size bucket filtration logic

  Fawke

  committed
  3d5760a

  Copy full SHA for 3d5760a

• Merge branch 'master' of https://github.com/prebid/Prebid.js into adv-size-config

  Fawke

  committed
  d8c96fc

  Copy full SHA for d8c96fc

Commits on Nov 26, 2019

• finish implmenation of getFilteredMediaTypes

  Fawke

  committed
  240cfce

  Copy full SHA for 240cfce

Commits on Dec 2, 2019

• implement getBids function

  Fawke

  committed
  8d7d35d

  Copy full SHA for 8d7d35d

• log useful information to the console

  Fawke

  committed
  5264373

  Copy full SHA for 5264373

• enable test workflow

  Fawke

  committed
  ac0007d

  Copy full SHA for ac0007d

Commits on Dec 4, 2019

• modify checkAdUnitSetup function to account for the new sizeConfig object

  Fawke

  committed
  4b876a6

  Copy full SHA for 4b876a6

Commits on Dec 5, 2019

• remove unrelated example

  Fawke

  committed
  c7b3816

  Copy full SHA for c7b3816

Commits on Dec 6, 2019

• add decider function to choose between sizeMapping v1 and sizeMapping v2

  Fawke

  committed
  751ceff

  Copy full SHA for 751ceff

• add getBidsHook for s2s bidders

  Fawke

  committed
  cbf2a61

  Copy full SHA for cbf2a61

• handle edge case where all mediaTypes get filtered out and the case when bidder gets filtered out

  Fawke

  committed
  60847f0

  Copy full SHA for 60847f0

Commits on Dec 7, 2019

• add test examples for banner media type

  Fawke

  committed
  5c35aed

  Copy full SHA for 5c35aed

• update label check to pick up the fist label operator instead of the last on incase there are multiple lables present

  Fawke

  committed
  ca521ba

  Copy full SHA for ca521ba

• added example for label checks with banner ad

  Fawke

  committed
  9ca28cf

  Copy full SHA for 9ca28cf

Commits on Dec 8, 2019

• add checkAdUnit setup hook on sizeMappingV2 modules to check presence of sizeConfig property in addition to doing normal adUnit checks

  Fawke

  committed
  eeb07e7

  Copy full SHA for eeb07e7

• restore old hello world example

  Fawke

  committed
  0d6e27c

  Copy full SHA for 0d6e27c

• give free pass to video mediaTypes configured with sizeConfig property, while keeping in place the essential sizeConfig checks

  Fawke

  committed
  208861a

  Copy full SHA for 208861a

• fixing minor bus and enchancing bidder level sizeConfig checks

  Fawke

  committed
  bbb1888

  Copy full SHA for bbb1888

• bugfix: checkBidderSizeConfigFormat

  Fawke

  committed
  72b5607

  Copy full SHA for 72b5607

• add more scenarios for testing sizeMapping V2

  Fawke

  committed
  d554866

  Copy full SHA for d554866

• small docs changes

  Fawke

  committed
  ff0d348

  Copy full SHA for ff0d348

Commits on Dec 11, 2019

• feedback1 changes

  Fawke

  committed
  0c30a75

  Copy full SHA for 0c30a75

Commits on Dec 12, 2019

• modify logic for bailing out

  Fawke

  committed
  613a830

  Copy full SHA for 613a830

• add module description

  Fawke

  committed
  4040fad

  Copy full SHA for 4040fad

Commits on Dec 13, 2019

• refactor isUsingNewSizeMapping function by making it a pure function

  Fawke

  committed
  1efc71c

  Copy full SHA for 1efc71c

• add unit test case for isUsingNewSizeMapping function

  Fawke

  committed
  723c298

  Copy full SHA for 723c298

• sync with master

  Fawke

  committed
  043626d

  Copy full SHA for 043626d

• made adUnit checks more robusts and fully make adUnit.mediaTypes mandatory

  Fawke

  committed
  4c20b1b

  Copy full SHA for 4c20b1b

Commits on Dec 17, 2019

• remove redundancy in checAdUnitSetupHook

  Fawke

  committed
  f0a29ca

  Copy full SHA for f0a29ca

Commits on Dec 19, 2019

• add banner units test cases for checkAdUnitSetupHook function

  Fawke

  committed
  2165a8b

  Copy full SHA for 2165a8b

Commits on Dec 20, 2019

• add video and native mediaTypes units test for checkAdUnitSetupHook function

  Fawke

  committed
  5afc8d1

  Copy full SHA for 5afc8d1

Commits on Dec 26, 2019

• rewrite some of the log messages

  Fawke

  committed
  66a43c5

  Copy full SHA for 66a43c5

• redefine log messages to make it simple to the end user

  Fawke

  committed
  b4cf490

  Copy full SHA for b4cf490

Commits on Dec 31, 2019

• code optimization done so that getFilteredMediaTypes function gets called only once per adUnit per auction

  Fawke

  committed
  57c27e6

  Copy full SHA for 57c27e6

• add code comments

  Fawke

  committed
  aa65876

  Copy full SHA for aa65876

Commits on Jan 2, 2020

• code refactorization and more unit test cases

  Fawke

  committed
  7a02628

  Copy full SHA for 7a02628

Commits on Jan 3, 2020

• more unit tests for getBids function

  Fawke

  committed
  72b69df

  Copy full SHA for 72b69df

Commits on Jan 4, 2020

• add sizeMapping usage example

  Fawke

  committed
  ce36722

  Copy full SHA for ce36722

• Merge branch 'master' of https://github.com/prebid/Prebid.js into adv-size-config

  Fawke

  committed
  47289a5

  Copy full SHA for 47289a5

• delete sizeMappingV2 directory

  Fawke

  committed
  8554891

  Copy full SHA for 8554891

Commits on Jan 7, 2020

• add doctype declaration

  Fawke

  committed
  f872991

  Copy full SHA for f872991

Commits on Jan 8, 2020

• fix LGTM alert and revert changes to pbjs_api.spec.js

  Fawke

  committed
  79d8b16

  Copy full SHA for 79d8b16

• fix LGTM alerts in sizeMappingV2_spec file

  Fawke

  committed
  aa53ccc

  Copy full SHA for aa53ccc

Commits on Mar 3, 2020

• Merge branch 'master' into module-sizeMappingV2

  Fawke

  committed
  49b7640

  Copy full SHA for 49b7640

• add file extension for imports

  Fawke

  committed
  b41fca8

  Copy full SHA for b41fca8