Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4674 Addition of DigiTrust vendor check for gdpr when cmp is present. #4698

Merged
merged 2 commits into from
Jan 22, 2020

Conversation

goosemanjack
Copy link
Contributor

Type of change

  • [X ] Bugfix

Description of change

This adds in the CMP vendor check for DigiTrust to the DigiTrust ID system module. When cmp is present and GDPR applies, this performs a check for consent specifically against the DigiTrust vendor ID to match behavior in the standalone DigiTrust ID system.

Other information

Issue #4674
#4674

Copy link

@samtingleff samtingleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

modules/digiTrustIdSystem.js Outdated Show resolved Hide resolved
test/spec/modules/digitrustIdSystem_spec.js Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Jan 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 22, 2020
@goosemanjack
Copy link
Contributor Author

Touching issue. Please review.

@stale stale bot removed the stale label Jan 22, 2020
@idettman idettman merged commit 39615f7 into prebid:master Jan 22, 2020
@benjaminclot
Copy link
Contributor

Giving consent by default (timeout or else) is not GDPR compliant.

@goosemanjack
Copy link
Contributor Author

@benjaminclot Thanks for your feedback and bringing this up. I will have our team review the behavior and adjust as necessary for compliance as this is a secondary check on top of the Prebid GDPR check.

@goosemanjack
Copy link
Contributor Author

Opened issue #4904

@goosemanjack goosemanjack deleted the issue-4674-gdpr branch February 27, 2020 18:16
hellsingblack pushed a commit to SublimeSkinz/Prebid.js that referenced this pull request Mar 5, 2020
…resent. (prebid#4698)

* prebid#4674 Addition of DigiTrust vendor check for gdpr when cmp is present.

* Fixing incorrect DigiTrust vendor ID. Should be 64, not 65.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants