Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static API option to the consentManagementUsp module for legacy 2.x. (#4685) #4705

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Add static API option to the consentManagementUsp module for legacy 2.x. (#4685) #4705

merged 1 commit into from
Jan 8, 2020

Conversation

harpere
Copy link
Collaborator

@harpere harpere commented Jan 8, 2020

The GDPR consent management module has a static configuration option. This change adds "static" as an API option to the consentManagementUsp module.

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

This change allows a static configuration such as the following to be used rather than the 'iab' API.

consentManagement: {
    usp: {
        cmpApi: 'static',
        consentData: {
            getUSPData: {
                uspString: '1YYY'
            }
        }
    }
}

Add static API option to the consentManagementUsp module. (#4685)
868dc96 
* Add static API option to the consentManagementUsp module.

The GDPR consent management module has a static configuration option. This change adds "static" as an API option to the consentManagementUsp module.

* Added a unit test for the static API option in the consentManagementUsp module.

* Updated the consentManagementUsp module static API config object to follow the recommended format.
@harpere harpere changed the title Add static API option to the consentManagementUsp module. (#4685) Add static API option to the consentManagementUsp module for legacy 2.x. (#4685) Jan 8, 2020
@jsnellbaker jsnellbaker self-requested a review January 8, 2020 18:07
jsnellbaker
jsnellbaker approved these changes Jan 8, 2020
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker added legacy needs 2nd review Core module updates require two approvals from the core team labels Jan 8, 2020
robertrmartinez
robertrmartinez approved these changes Jan 8, 2020
View reviewed changes
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice.

Thanks Eric, looks good!

@harpere harpere merged commit 5f51fb3 into 2.44.x-legacy Jan 8, 2020
@jsnellbaker jsnellbaker mentioned this pull request Jan 9, 2020
Merged
9 tasks
@harpere harpere removed the needs 2nd review Core module updates require two approvals from the core team label Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

@robertrmartinez robertrmartinez robertrmartinez approved these changes

Assignees

@robertrmartinez robertrmartinez

Labels
legacy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harpere @robertrmartinez @jsnellbaker