Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(usersync): corrected usersync url #4712

Merged
merged 4 commits into from
Jan 21, 2020

Conversation

sourabhg
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Corrected the user sync url

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@jsnellbaker
Copy link
Collaborator

@sourabhg Can you please review your unit tests and make the same change there as well? There are a few failures in the circleci that have the details to which tests.

@jsnellbaker jsnellbaker self-requested a review January 10, 2020 13:53
@jsnellbaker jsnellbaker self-assigned this Jan 10, 2020
@sourabhg
Copy link
Contributor Author

@jsnellbaker resolved the issues.

@jsnellbaker
Copy link
Collaborator

@sourabhg Thanks for making the unit test update. When I tried to test this new sync url just now, I was getting a 404 error from the new sync endpoint.

Can you check on your end? If there's anything you want me to provide to help investigate, please let me know.

Thanks.

@sourabhg
Copy link
Contributor Author

@jsnellbaker : updated to the correct url https://cdn.deepintent.com/syncpixel.html this is now the latest correct url and it works fine. Please merge.

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sourabhg Thanks for making the update. Looks good now.

@jsnellbaker jsnellbaker merged commit d67768b into prebid:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants