if seatBidId is on bidResponse, always use it #4732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertrmartinez
commented
Jan 14, 2020
| @@ -224,7 +224,6 @@ const MOCK = { | |||
| 'transactionId': 'c116413c-9e3f-401a-bee1-d56aec29a1d4', | |||
| 'sizes': [[1000, 300], [970, 250], [728, 90]], | |||
| 'bidId': '3bd4ebb1c900e2', | |||
| 'seatBidId': 'aaaa-bbbb-cccc-dddd', | |||
There was a problem hiding this comment.
This is the mock of the bidRequestObject, which would never have seatBidId in it since seatBidId is a bidResponse field.
So not realistic to have it here.
robertrmartinez
commented
Jan 14, 2020
| // RP server banner overwrites bidId with bid.seatBidId | ||
| if (utils.deepAccess(bid, 'bidResponse.seatBidId') && bid.bidder === 'rubicon' && bid.source === 'server' && ['video', 'banner'].some(i => utils.deepAccess(bid, 'bidResponse.mediaType') === i)) { | ||
| bid.seatBidId = bid.bidResponse.seatBidId; | ||
| } |
There was a problem hiding this comment.
The line bid.bidResponse = parseBidResponse(args, bid.bidResponse);
Adds seatBidId to the internal bidResponse in the analytics adapter. And if that is present, it overwrites the
internal bidRequest.bidId which is sent to Analytics.
This bid.seatBidId is not referenced or used anywhere else in the code.
So does not make sense to add it to this bid object.
bretg
approved these changes
Jan 14, 2020
harpere
approved these changes
Jan 15, 2020
audiencerun
pushed a commit
to audiencerun/Prebid.js
that referenced
this pull request
Jan 20, 2020
hellsingblack
pushed a commit
to SublimeSkinz/Prebid.js
that referenced
this pull request
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
For Rubicon analytics adapter if there is a
seatBidIdon the bidResponse object then we will be sure to use that as thebidIdwe send to the batched endpoint.This is just removing a couple unnecessary checks and adding a test.