Sonobi - removed unneeded query params #4735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonGoSonobi
changed the title
bretg
approved these changes
Jan 16, 2020
|
Looks fine, but please look over the params on your documentation page. Looks like maybe you want to get rid of the 'hfa' option there? https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/sonobi.md |
audiencerun
pushed a commit
to audiencerun/Prebid.js
that referenced
this pull request
Jan 20, 2020
* removed tdid query param since it is passed in the userid obj * removed pub common id being passed to hfa
|
@bretg hfa is still an option. We just dont want to default it to pub common id anymore. |
hellsingblack
pushed a commit
to SublimeSkinz/Prebid.js
that referenced
this pull request
Mar 5, 2020
* removed tdid query param since it is passed in the userid obj * removed pub common id being passed to hfa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Removed TDID param from bid request since it is passed into the userid param now.
Removed pub common id as a value for hfa query param