Support Native #4759
Support Native #4759
Conversation
Make it possible to pass dynamic parameters to adapter
Pass metadata from adapter
|
Don't think the ci/circleci issue is related to this PR? |
| options: bid.params.options | ||
| }; | ||
|
|
||
| if (bid.mediaTypes && bid.mediaTypes.banner && bid.mediaTypes.native) { | ||
| adRequest.banner = true; |
There was a problem hiding this comment.
Why does setting this matter if native is in the mediaTypes?
There was a problem hiding this comment.
It's related to how it works in the backend. It only needs setting if both banner and native is enabled, otherwise (if not native) banner is implied.
Btw. thanks for all the input, I will fix those things for the next PR.
| adRequest.banner = true; | ||
| } | ||
|
|
||
| if (bid.mediaTypes && bid.mediaTypes.native) { |
There was a problem hiding this comment.
I have a personal connection with using the deepAccess util for these kinds of checks.
if(deepAccess(bid, 'mediaTypes.native')
But definitely not necessary, just like to point it out so people are aware of it!
| } | ||
|
|
||
| function getSizes(bid) { | ||
| if (typeof utils.deepAccess(bid, 'mediaTypes.banner.sizes') !== 'undefined') { |
There was a problem hiding this comment.
I see you already are using deepAccess! nice :)
Can probably be changed to leave off the typeof {} !== 'undefined' maybe?
Since if it was not defined it will just return undefined which is falsely.
No big deal though.
Type of change
Description of change
Support native ads + get banner size from mediaTypes.banner