Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v3 #4762

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Update to v3 #4762

merged 1 commit into from
Jan 23, 2020

Conversation

VideoReach
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Upgrade VideoReach adapter code for Prebid 3, by removing the use of deprecated functions. No other changes were introduced.

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VideoReach

Do you happen to have a set of test params that return a valid bid + usersync URL?

While everything appears to be good, I'd like to verify the end-to-end workflow (since it looks like there was some refactoring in the userSync part of the adapter). The params in the md file don't appear to give an actual bid.

Please let me know. Thanks!

@VideoReach
Copy link
Contributor Author

Hi @jsnellbaker,

thanks for your reply.
Sure, you can test it with the following parameters:

TagId: MS8OW

The video will load into a DIV with ID TextContent

Thank you!

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VideoReach
Thanks for sending over that test param. I got the bid successfully.

LGTM

@jsnellbaker jsnellbaker merged commit fd0a001 into prebid:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants