Update to v3 #4762
Merged
Update to v3 #4762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
requested changes
Jan 22, 2020
There was a problem hiding this comment.
Hi @VideoReach
Do you happen to have a set of test params that return a valid bid + usersync URL?
While everything appears to be good, I'd like to verify the end-to-end workflow (since it looks like there was some refactoring in the userSync part of the adapter). The params in the md file don't appear to give an actual bid.
Please let me know. Thanks!
|
Hi @jsnellbaker, thanks for your reply.
The video will load into a DIV with ID Thank you! |
jsnellbaker
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
@VideoReach
Thanks for sending over that test param. I got the bid successfully.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Upgrade VideoReach adapter code for Prebid 3, by removing the use of deprecated functions. No other changes were introduced.