Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore adman bidadapter #4839

Merged
merged 21 commits into from
Feb 19, 2020
Merged

Restore adman bidadapter #4839

merged 21 commits into from
Feb 19, 2020

Conversation

SmartyAdman
Copy link
Contributor

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

General changes to be compliant with latest Prebid

  • test parameters for validating bids
{
                    code: 'placementId_0',
                    mediaTypes: {
                        video: {
                            sizes: [[300, 250]],
                        }
                    },
                    bids: [
                        {
                            bidder: 'adman',
                            params: {
                                placementId: 0,
                                traffic: 'video'
                            }
                        }
                    ]
                },
                {
                    code: 'placementId_0',
                    mediaTypes: {
                        native: {}
                    },
                    bids: [
                        {
                            bidder: 'adman',
                            params: {
                                placementId: 0,
                                traffic: 'native'
                            }
                        }
                    ]
                },
                {
                    code: 'placementId_0',
                    mediaTypes: {
                        banner: {
                            sizes: [[300, 250]],
                        }
                    },
                    bids: [
                        {
                            bidder: 'adman',
                            params: {
                                placementId: 0,
                                traffic: 'banner',
                            }
                        }
                    ]
                }

@jsnellbaker jsnellbaker self-requested a review February 13, 2020 14:18
@jsnellbaker jsnellbaker self-assigned this Feb 13, 2020
@jsnellbaker jsnellbaker merged commit 7df057b into prebid:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants