Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented schain support for prebid and updated documentation examples for prebid3.0 #4844

Merged
merged 2 commits into from
Feb 16, 2020

Conversation

rajcspsg
Copy link
Contributor

@rajcspsg rajcspsg commented Feb 11, 2020

  • Feature

Description of change

Support for schain object in synacormediaBidder Adapter

@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2020

This pull request introduces 1 alert when merging 3f9af6edef3bd6f15de53b749c7913206cac8278 into c99c78f - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2020

This pull request introduces 1 alert when merging 3cd47d00efaf08263b5bf3dd2de6b28740f56afe into 720038e - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2020

This pull request introduces 1 alert when merging bb1169d15471489300334eca6ce733582a788776 into 41fb95f - view on LGTM.com

new alerts:

  • 1 for Useless conditional

Copy link

@bx2 bx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bx2 bx2 added needs 2nd review Core module updates require two approvals from the core team and removed needs review labels Feb 15, 2020
@bx2 bx2 assigned bx2 and unassigned bx2 Feb 15, 2020
@bx2 bx2 requested review from jsnellbaker and removed request for jsnellbaker February 15, 2020 07:15
@bx2 bx2 added LGTM and removed needs 2nd review Core module updates require two approvals from the core team labels Feb 15, 2020
@bx2 bx2 merged commit 5b53b37 into prebid:master Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants