Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating criteo-direct-rsa-validate to 1.1.0 to fix issue #4851 #4852

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

leonardlabat
Copy link
Contributor

##Type of change

  • Bugfix

Description of change

Fixing issue #4851
We've release a new version of our library. Dependencies were wrongly typed as 'dependencies' instead of 'devDependencies'. Moreover, the 'build' dependency was not used and could be removed.

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit 7279255 into prebid:master Feb 19, 2020
hellsingblack pushed a commit to SublimeSkinz/Prebid.js that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants