Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ByPlay Adapter #4854

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

daisato-tsumiki
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

I had to supply adUnitCode to renderer.

@daisato-tsumiki daisato-tsumiki force-pushed the feature/update-byplay-adapter branch 2 times, most recently from 58ba77b to 2b452f2 Compare February 18, 2020 06:05
@daisato-tsumiki
Copy link
Contributor Author

@mike-chowla Would you please review?

Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit ac0ce27 into prebid:master Feb 25, 2020
monofonik pushed a commit to playground-xyz/Prebid.js that referenced this pull request Feb 25, 2020
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants