Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schain support #4870

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Schain support #4870

merged 1 commit into from
Feb 19, 2020

Conversation

rajcspsg
Copy link
Contributor

Type of change

  • [x ] Code style update (formatting, local variables)
  • [ x] Refactoring (no functional changes, no api changes)

Description of change

minor refactoring/code style changes to schain implementation

@rajcspsg
Copy link
Contributor Author

@bx2 Is it possible to rerun the tests. Looks like test failures are not from my code.

@bx2
Copy link

bx2 commented Feb 18, 2020 •
edited
Loading

@rajcspsg I don't think that was me who reviewed your previous MR - I think it was @musikele.
I agree that the failures were not caused by your code but rather by the issues we are having with circleci.

@musikele can you take a look again?

@bx2 bx2 requested a review from musikele February 18, 2020 19:50
@musikele
Copy link
Contributor

LGTM

@musikele musikele merged commit d30b0a6 into prebid:master Feb 19, 2020
hellsingblack pushed a commit to SublimeSkinz/Prebid.js that referenced this pull request Mar 5, 2020
@rajcspsg @hellsingblack
minor code changes for schain implementation (prebid#4870)
6143aaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musikele musikele Awaiting requested review from musikele

Assignees

@musikele musikele

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajcspsg @bx2 @musikele