Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bridgewell bid adapter #4920

Merged
merged 6 commits into from
Mar 6, 2020
Merged

Update bridgewell bid adapter #4920

merged 6 commits into from
Mar 6, 2020

Conversation

lawliet1995
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Add consumed to server bid response after it is already used.

matchedResponse.consumed = true;

Use aduniCode to match response and request if property aduniCode is exist in response.

if (res.adUnitCode) {
     return res.adUnitCode === adUnitCode;
}

Add test for above features.

harpere
harpere requested changes Mar 5, 2020
View reviewed changes
Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove package-lock.json from the PR

@harpere harpere self-assigned this Mar 5, 2020
@lawliet1995
Copy link
Contributor Author

@harpere
Thanks for your advice. package-lock.json has been removed form this PR.

@harpere harpere added LGTM and removed needs review labels Mar 6, 2020
@harpere harpere merged commit ef66d93 into prebid:master Mar 6, 2020
bmwcmw pushed a commit to criteo-forks/Prebid.js that referenced this pull request Mar 31, 2020
@lawliet1995
Update bridgewell bid adapter (prebid#4920)
14ca45b 
* Add consumed to bid response

* Modify test

* Use include instead of containAllKeys

* Use adUnitCode to match response and request

* Add test

* Restore packageLock
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
@lawliet1995 @rjvelicaria
Update bridgewell bid adapter (prebid#4920)
4c8475a 
* Add consumed to bid response

* Modify test

* Use include instead of containAllKeys

* Use adUnitCode to match response and request

* Add test

* Restore packageLock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harpere harpere harpere requested changes

Assignees

@harpere harpere

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawliet1995 @harpere