SublimeBidAdapter: Update to version 0.5.1 #4977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, taking a look at this now. We do not allow adapters to fire pixels inside of non registered pixel events, so sending an event for every bidResponse is not allowed. Adapters should only be sending pixels on the allowed events like, onTimeout, onBidWon etc |
robertrmartinez
requested changes
Mar 31, 2020
* Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event
SublimeLeo
force-pushed
the
sublime-adapter
branch
from
e0feea2 to
e14b9e9
Compare
robertrmartinez
requested changes
Apr 7, 2020
modules/sublimeBidAdapter.js
Outdated
| const bidResponses = []; | ||
| const response = serverResponse.body; | ||
|
|
||
| sendEvent('dintres'); |
There was a problem hiding this comment.
pixel fires outside of the pixel listen hooks is not allowed. please remove this.
modules/sublimeBidAdapter.js
Outdated
|
|
||
| bidResponses.push(bidResponse); | ||
| } | ||
| sendEvent('bida', true); |
There was a problem hiding this comment.
same as above, please remove
modules/sublimeBidAdapter.js
Outdated
| sendEvent('bida', true); | ||
| bidResponses.push(bidResponse); | ||
| } else { | ||
| sendEvent('dnobid'); |
modules/sublimeBidAdapter.js
Outdated
| */ | ||
| function onTimeout(timeoutData) { | ||
| log('Timeout from adapter', timeoutData); | ||
| sendEvent('dbidtimeout', true); |
There was a problem hiding this comment.
pixels are allowed onTimeout so you can leave this
* add prebid version of adapter * Feature/update sublime adapter (#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon * Incremente version of sublimeBidAdapter * Renamed pixel for timeout and introduce gvlid * Remove unnecessary params for sendEvent Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com> Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com> Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>
|
Hello @robertrmartinez, sorry for the delay! |
|
Oops, it seems that we have errors with the CI. |
|
CI should be fine now! |
|
Hi sorry for the delay, have been swamped. Will get this reviewed and merged tomorrow! |
|
Cool, thank you! Let me know if I missed anything! |
robertrmartinez
approved these changes
Apr 21, 2020
iggyfisk
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Jun 22, 2020
* add prebid version of adapter * Feature/update sublime adapter (prebid#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon (prebid#22) * add prebid version of adapter * Feature/update sublime adapter (prebid#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon * Incremente version of sublimeBidAdapter * Renamed pixel for timeout and introduce gvlid * Remove unnecessary params for sendEvent Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com> Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com> Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com> * Remove trailing-space * Fix version in tests Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com> Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Hello, we made changes on our adapter!
We modified the code style, added some pixels to have more visibility on our adapter behaviour and made debug easier.