CRITEO RTUS Integration with Yieldmo Prebid #5075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream sync
This reverts commit 4fd8634.
pass along gdpr consent string and gdpr applies through get
add stringified schain
change parameter names
updates bidder module to be 3.0 compliant, and tests
Fs 7766 remove openxoustream
…erer object in bidderRequest
remove utils functions that will be depricated in 3.0 and use new ref…
…pliant ad units object
use prebids gettopwindow util functions. update markdown with 3.0 com…
Pass along us_privacy string
This reverts commit 4fd8634.
…erer object in bidderRequest
…pliant ad units object
Rebase upstream
CRITEO RTUS For prebid
This reverts commit 0185407.
Fawke
requested changes
Apr 7, 2020
There was a problem hiding this comment.
Hi @mglowackiym,
The change looks fine to me. I've tested with the hello world page on prebid and getting a response back. But when I checked your response headers, I don't see this key Content-Encoding. Ideally, it should be set to gzip. Can you please add it to the server response header?
|
@Fawke we made the update to our ad response. It should be now |
rjvelicaria
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Apr 9, 2020
* update maintainer email * add stringified schain * Revert "add stringified schain" This reverts commit 4fd8634. * pass along gdpr consent string and gdpr applies through get * use paramter gdprConsent * add stringified schain * don't change other files * change parameter namves * updates bidder module to be 3.0 compliant, and tests * deletes openxoutstream adapter * fix broken yieldmo test * remove log * remove utils functions that will be depricated in 3.0 and use new referer object in bidderRequest * use prebids gettopwindow util functions. update markdown with 3.0 compliant ad units object * Pass along us_privacy string * remove blank.min * Fix unit tests and remove unused variables and methods * add stringified schain * add stringified schain * Revert "add stringified schain" This reverts commit 4fd8634. * pass along gdpr consent string and gdpr applies through get * use paramter gdprConsent * don't change other files * change parameter namves * updates bidder module to be 3.0 compliant, and tests * deletes openxoutstream adapter * fix broken yieldmo test * remove log * remove utils functions that will be depricated in 3.0 and use new referer object in bidderRequest * use prebids gettopwindow util functions. update markdown with 3.0 compliant ad units object * Pass along us_privacy string * update maintainer email * add stringified schain * Revert "add stringified schain" This reverts commit 4fd8634. * add stringified schain * don't change other files * change parameter namves * updates bidder module to be 3.0 compliant, and tests * fix broken yieldmo test * remove utils functions that will be depricated in 3.0 and use new referer object in bidderRequest * use prebids gettopwindow util functions. update markdown with 3.0 compliant ad units object * Pass along us_privacy string * Clean up console * Do not undo my featureeee * CRITEO RTUS For prebid * Tests for CRITEO RTUS For prebid * Revert "Do not undo my featureeee" This reverts commit 0185407. * linting * add test back in: Co-authored-by: Melody Li <melodyli@ip-192-168-2-119.ec2.internal> Co-authored-by: Elber Carneiro <elber@yieldmo.com> Co-authored-by: Elber Carneiro <elberdev@gmail.com> Co-authored-by: Melody Li <melody@yieldmo.com> Co-authored-by: Melody Li <ml867@cornell.edu> Co-authored-by: Andrew Holz <holz.andrew@gmail.com> Co-authored-by: Michal <mike@lamiglo.com>
redaguermas
added a commit
to redaguermas/Prebid.js
that referenced
this pull request
Apr 16, 2020
* 'master' of https://github.com/prebid/Prebid.js: (102 commits) Marsmedia - Add vastXml and fix id response (prebid#5067) PubMatic adapter to support image sync (prebid#5104) minor consentManagement fix (prebid#5050) fix circle ci failing tests (prebid#5113) Add Relaido Adapter (prebid#5101) Add new bid adapter for ConnectAd (prebid#4806) change payload (prebid#5105) Utils updates (prebid#5092) Read OpenRTB app objects if set in config + bug fix for when ad units are reloaded (prebid#5086) Criteo : added first party data mapping to bidder request (prebid#4954) updateAdGenerationManual (prebid#5032) New bid adapter: Wipes (prebid#5051) Prebid manager analytics utm tags (prebid#4998) CRITEO RTUS Integration with Yieldmo Prebid (prebid#5075) isSafariBrowser update (prebid#5077) Support min &max duration for onevideo (prebid#5079) increment pre version Prebid 3.15.0 release prebid#5011 Fix to set Secure attribute on cookie when SameSite=none (prebid#5064) Prebid adapter for windtalker (prebid#5040) ...
iggyfisk
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Jun 22, 2020
* update maintainer email * add stringified schain * Revert "add stringified schain" This reverts commit 4fd8634. * pass along gdpr consent string and gdpr applies through get * use paramter gdprConsent * add stringified schain * don't change other files * change parameter namves * updates bidder module to be 3.0 compliant, and tests * deletes openxoutstream adapter * fix broken yieldmo test * remove log * remove utils functions that will be depricated in 3.0 and use new referer object in bidderRequest * use prebids gettopwindow util functions. update markdown with 3.0 compliant ad units object * Pass along us_privacy string * remove blank.min * Fix unit tests and remove unused variables and methods * add stringified schain * add stringified schain * Revert "add stringified schain" This reverts commit 4fd8634. * pass along gdpr consent string and gdpr applies through get * use paramter gdprConsent * don't change other files * change parameter namves * updates bidder module to be 3.0 compliant, and tests * deletes openxoutstream adapter * fix broken yieldmo test * remove log * remove utils functions that will be depricated in 3.0 and use new referer object in bidderRequest * use prebids gettopwindow util functions. update markdown with 3.0 compliant ad units object * Pass along us_privacy string * update maintainer email * add stringified schain * Revert "add stringified schain" This reverts commit 4fd8634. * add stringified schain * don't change other files * change parameter namves * updates bidder module to be 3.0 compliant, and tests * fix broken yieldmo test * remove utils functions that will be depricated in 3.0 and use new referer object in bidderRequest * use prebids gettopwindow util functions. update markdown with 3.0 compliant ad units object * Pass along us_privacy string * Clean up console * Do not undo my featureeee * CRITEO RTUS For prebid * Tests for CRITEO RTUS For prebid * Revert "Do not undo my featureeee" This reverts commit 0185407. * linting * add test back in: Co-authored-by: Melody Li <melodyli@ip-192-168-2-119.ec2.internal> Co-authored-by: Elber Carneiro <elber@yieldmo.com> Co-authored-by: Elber Carneiro <elberdev@gmail.com> Co-authored-by: Melody Li <melody@yieldmo.com> Co-authored-by: Melody Li <ml867@cornell.edu> Co-authored-by: Andrew Holz <holz.andrew@gmail.com> Co-authored-by: Michal <mike@lamiglo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR contains a new feature which is an integration of Criteo with Yieldmo's prebid.
The implementation follows guidelines described here and has been tested successfully both locally and by our internal testing team. Moreover, in this PR a new test has been added to cover the new use case. Lastly, Prebid linting rules have been applied as part of this. Please note that test placement for this adapter only renders on mobile.
Other information
This change has been verified locally and by internal testing team. Feature testing and internal PR review has been completed under this PR. Please note that test placement for this adapter only renders on mobile.